From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E547C433DF for ; Thu, 4 Jun 2020 13:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30BAC20738 for ; Thu, 4 Jun 2020 13:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728533AbgFDNVI (ORCPT ); Thu, 4 Jun 2020 09:21:08 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:51864 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728450AbgFDNVE (ORCPT ); Thu, 4 Jun 2020 09:21:04 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 1EC851C0BD2; Thu, 4 Jun 2020 15:21:03 +0200 (CEST) Date: Thu, 4 Jun 2020 15:21:02 +0200 From: Pavel Machek To: Dan Murphy Cc: Jacek Anaszewski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH Subject: Re: [PATCH v18 4/4] leds: multicolor: Introduce a multicolor class definition Message-ID: <20200604132102.GC7222@duo.ucw.cz> References: <20200324181434.24721-1-dmurphy@ti.com> <20200324181434.24721-5-dmurphy@ti.com> <9a707fe6-31c6-da9e-9372-51ca21bf3c88@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sHrvAb52M6C8blB9" Content-Disposition: inline In-Reply-To: <9a707fe6-31c6-da9e-9372-51ca21bf3c88@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sHrvAb52M6C8blB9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > +Description: read > > > + Maximum intensity level for the LED color within the array. > > > + The max intensities for each color must be entered based on the > > > + color_index array. > > I wonder if we should mention here that each LED within a cluster should > > have the same maximum intensity for linear color lightness calculation > > via brightness file. >=20 > Does it really have to? Yes it does. Anything else is unneccessarily complex. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --sHrvAb52M6C8blB9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXtj1PgAKCRAw5/Bqldv6 8qatAJ4u6W8VQzR8pf32e+wX/xMXb1e10QCeOOW9iBoX3jcny6s21E32jzpK7jM= =DoKN -----END PGP SIGNATURE----- --sHrvAb52M6C8blB9--