From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E1DC433E1 for ; Thu, 4 Jun 2020 13:52:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 044DB207DF for ; Thu, 4 Jun 2020 13:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728809AbgFDNwO (ORCPT ); Thu, 4 Jun 2020 09:52:14 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:34932 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728688AbgFDNwN (ORCPT ); Thu, 4 Jun 2020 09:52:13 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 912681C0BD2; Thu, 4 Jun 2020 15:52:12 +0200 (CEST) Date: Thu, 4 Jun 2020 15:52:12 +0200 From: Pavel Machek To: Gene Chen Cc: jacek.anaszewski@gmail.com, matthias.bgg@gmail.com, dmurphy@ti.com, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Subject: Re: [PATCH] leds: mt6360: Add LED driver for MT6360 Message-ID: <20200604135212.GI7222@duo.ucw.cz> References: <1591252004-12681-1-git-send-email-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qLni7iB6Dl8qUSwk" Content-Disposition: inline In-Reply-To: <1591252004-12681-1-git-send-email-gene.chen.richtek@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qLni7iB6Dl8qUSwk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index c664d84..c47be91 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -229,6 +229,17 @@ config LEDS_MT6323 > This option enables support for on-chip LED drivers found on > Mediatek MT6323 PMIC. > =20 > +config LEDS_MT6360 > + tristate "LED Support for Mediatek MT6360 PMIC" > + depends on LEDS_CLASS_FLASH && OF > + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS > + depends on MFD_MT6360 > + help > + This option enables support for dual Flash LED drivers found on > + Mediatek MT6360 PMIC. > + Support Torch and Strobe mode independently current source. > + Include Low-VF and short protection. This should be in english... and should not contain "advertising". Just delete last two lines. More useful information would be listing hardware where this is often found. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --qLni7iB6Dl8qUSwk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXtj8jAAKCRAw5/Bqldv6 8sQ/AJ9RSpXXojs6+tLysx6O8BZD+n8ZwQCgrtkhweKtov6zJaZLivlz+10eSwA= =1Hm6 -----END PGP SIGNATURE----- --qLni7iB6Dl8qUSwk--