From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EBDFC433DF for ; Thu, 4 Jun 2020 15:20:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB930207D8 for ; Thu, 4 Jun 2020 15:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591284009; bh=w2uxMGuh2+1k7LPoRuxUyCewdA+D0PptbvSog58dJiE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bMpGgprSH6P24M4feZGEsFV6x0a1N3+3TmQ/t2DC4E79EXzAaLjymKLkWyOm0JnDH rne4uWD5SS3LQRzSO1flyy+JyjrNOepz0NnhEAccObk06Y+od8H0C93Z2eQEDNHP96 UtG9Jr5eU6fgjyW47Byn51m0lGimILV4HMoxCAWM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729378AbgFDPUI (ORCPT ); Thu, 4 Jun 2020 11:20:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:42548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729035AbgFDPUH (ORCPT ); Thu, 4 Jun 2020 11:20:07 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D40D8206E6; Thu, 4 Jun 2020 15:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591284007; bh=w2uxMGuh2+1k7LPoRuxUyCewdA+D0PptbvSog58dJiE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W+f0x/FEf8ckxVQEj4c9o8Sbp2+VQ4FAQSK+8OHNGhIInSIYdLal8pWCCNaPj+G6V 4HfPBpL4h6mXmSMBnKRvcLZHWbD2kv+SvkhdQIXzZwlnHNpXCMrpJCg9WvsZda25/U mnPnjW+sbeRpfeHXwCs/6+Pl17xFrsbh45/X29Js= Date: Thu, 4 Jun 2020 16:20:02 +0100 From: Will Deacon To: Jordan Crouse Cc: linux-arm-msm@vger.kernel.org, Joerg Roedel , Robin Murphy , Sai Prakash Ranjan , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu: Mark qcom_smmu_client_of_match as possibly unused Message-ID: <20200604152002.GC3650@willie-the-truck> References: <20200603211507.27756-1-jcrouse@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200603211507.27756-1-jcrouse@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2020 at 03:15:07PM -0600, Jordan Crouse wrote: > When CONFIG_OF=n of_match_device() gets pre-processed out of existence > leaving qcom-smmu_client_of_match unused. Mark it as possibly unused to > keep the compiler from warning in that case. > > Fixes: 0e764a01015d ("iommu/arm-smmu: Allow client devices to select direct mapping") > Reported-by: kbuild test robot > Signed-off-by: Jordan Crouse > --- > > drivers/iommu/arm-smmu-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c > index cf01d0215a39..063b4388b0ff 100644 > --- a/drivers/iommu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm-smmu-qcom.c > @@ -12,7 +12,7 @@ struct qcom_smmu { > struct arm_smmu_device smmu; > }; > > -static const struct of_device_id qcom_smmu_client_of_match[] = { > +static const struct __maybe_unused of_device_id qcom_smmu_client_of_match[] = { Yikes, I've never seen that between the 'struct' and the struct name before! I'd be inclined to stick it at the end, right before the '='. With that: Acked-by: Will Deacon Will