From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC71C433E0 for ; Fri, 5 Jun 2020 13:26:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78CDC20772 for ; Fri, 5 Jun 2020 13:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727111AbgFEN0B (ORCPT ); Fri, 5 Jun 2020 09:26:01 -0400 Received: from mga02.intel.com ([134.134.136.20]:16169 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbgFEN0A (ORCPT ); Fri, 5 Jun 2020 09:26:00 -0400 IronPort-SDR: sjSG+MwpU7tDcBFJzmoDFNhpoyXMHvgt6gZkmnhYKDcYyaCgnjuQ+uHENMwB/634CgX3Dq+z3F e+nNIYuRzXeQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2020 06:25:59 -0700 IronPort-SDR: QqxE7vVCy+o4w+yOREYmgWZnFs85Wh6JiXNHvhNhepNpRslwIXDBPaaHax64B+3tgyJr2LBEAt oaWmWd4bnrag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,476,1583222400"; d="scan'208";a="294688917" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004.fm.intel.com with ESMTP; 05 Jun 2020 06:25:56 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jhCMA-00B2K3-BC; Fri, 05 Jun 2020 16:25:58 +0300 Date: Fri, 5 Jun 2020 16:25:58 +0300 From: Andy Shevchenko To: Alexander Gordeev Cc: Linux Kernel Mailing List , linux-s390@vger.kernel.org, Stable , Yury Norov , Amritha Nambiar , Arnaldo Carvalho de Melo , Chris Wilson , Kees Cook , Matthew Wilcox , Miklos Szeredi , Rasmus Villemoes , Steffen Klassert , "Tobin C . Harding" , Vineet Gupta , Will Deacon , Willem de Bruijn Subject: Re: [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs Message-ID: <20200605132558.GM2428291@smile.fi.intel.com> References: <1589798090-11136-1-git-send-email-agordeev@linux.ibm.com> <20200518115059.GA19150@oc3871087118.ibm.com> <20200602102430.GA17703@oc3871087118.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200602102430.GA17703@oc3871087118.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 02, 2020 at 12:24:31PM +0200, Alexander Gordeev wrote: > On Mon, May 18, 2020 at 01:50:59PM +0200, Alexander Gordeev wrote: > > On Mon, May 18, 2020 at 02:33:43PM +0300, Andy Shevchenko wrote: > > > On Mon, May 18, 2020 at 1:40 PM Alexander Gordeev > > > wrote: > > > > > > > > Commit 2d6261583be0 ("lib: rework bitmap_parse()") does > > > > not take into account order of halfwords on 64-bit big > > > > endian architectures. > > > > > > Thanks for report and the patch! > > > > > > Did it work before? Can we have a test case for that that we will see > > > the failure? > > > > The test exists and enabled with CONFIG_TEST_BITMAP. > > It does not appear ever passed before on 64 BE. > > It does not fail on 64 LE for me either. > > Hi Andy et al, > > Any feedback on the fix? Does it work on 64 LE for you? Test case, please. Yes, you can simulate BE test case on LE platform and vise versa. -- With Best Regards, Andy Shevchenko