From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 890CFC433DF for ; Sun, 7 Jun 2020 20:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 646C72067B for ; Sun, 7 Jun 2020 20:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727981AbgFGUY6 (ORCPT ); Sun, 7 Jun 2020 16:24:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:60100 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727065AbgFGUY6 (ORCPT ); Sun, 7 Jun 2020 16:24:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 95E8AAC4A; Sun, 7 Jun 2020 20:24:58 +0000 (UTC) Received: by lion.mk-sys.cz (Postfix, from userid 1000) id 3F05F602EB; Sun, 7 Jun 2020 22:24:52 +0200 (CEST) Date: Sun, 7 Jun 2020 22:24:52 +0200 From: Michal Kubecek To: Oleksij Rempel Cc: Andrew Lunn , "David S. Miller" , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Jonathan Corbet , "John W. Linville" , David Jander , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , mkl@pengutronix.de, Marek Vasut , Christian Herber , Amit Cohen , Petr Machata Subject: Re: [PATCH v2 3/3] netlink: add LINKSTATE SQI support Message-ID: <20200607202452.md4nnp47cfjetylp@lion.mk-sys.cz> References: <20200528115414.11516-1-o.rempel@pengutronix.de> <20200528115414.11516-4-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6rexytvx3x3wksna" Content-Disposition: inline In-Reply-To: <20200528115414.11516-4-o.rempel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6rexytvx3x3wksna Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 28, 2020 at 01:54:14PM +0200, Oleksij Rempel wrote: > Some PHYs provide Signal Quality Index (SQI) if the link is in active > state. This information can help to diagnose cable and system design > related issues. >=20 > Signed-off-by: Oleksij Rempel > Reviewed-by: Florian Fainelli Reviewed-by: Michal Kubecek > --- > netlink/desc-ethtool.c | 2 ++ > netlink/settings.c | 16 ++++++++++++++++ > 2 files changed, 18 insertions(+) >=20 > diff --git a/netlink/desc-ethtool.c b/netlink/desc-ethtool.c > index b0a793c..8f4c36b 100644 > --- a/netlink/desc-ethtool.c > +++ b/netlink/desc-ethtool.c > @@ -93,6 +93,8 @@ static const struct pretty_nla_desc __linkstate_desc[] = =3D { > NLATTR_DESC_INVALID(ETHTOOL_A_LINKSTATE_UNSPEC), > NLATTR_DESC_NESTED(ETHTOOL_A_LINKSTATE_HEADER, header), > NLATTR_DESC_BOOL(ETHTOOL_A_LINKSTATE_LINK), > + NLATTR_DESC_U32(ETHTOOL_A_LINKSTATE_SQI), > + NLATTR_DESC_U32(ETHTOOL_A_LINKSTATE_SQI_MAX), > }; > =20 > static const struct pretty_nla_desc __debug_desc[] =3D { > diff --git a/netlink/settings.c b/netlink/settings.c > index 851de15..cd4b9a7 100644 > --- a/netlink/settings.c > +++ b/netlink/settings.c > @@ -638,6 +638,22 @@ int linkstate_reply_cb(const struct nlmsghdr *nlhdr,= void *data) > printf("\tLink detected: %s\n", val ? "yes" : "no"); > } > =20 > + if (tb[ETHTOOL_A_LINKSTATE_SQI]) { > + uint32_t val =3D mnl_attr_get_u32(tb[ETHTOOL_A_LINKSTATE_SQI]); > + > + print_banner(nlctx); > + printf("\tSQI: %u", val); > + > + if (tb[ETHTOOL_A_LINKSTATE_SQI_MAX]) { > + uint32_t max; > + > + max =3D mnl_attr_get_u32(tb[ETHTOOL_A_LINKSTATE_SQI_MAX]); > + printf("/%u\n", max); > + } else { > + printf("\n"); > + } > + } > + > return MNL_CB_OK; > } > =20 > --=20 > 2.26.2 >=20 --6rexytvx3x3wksna Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEWN3j3bieVmp26mKO538sG/LRdpUFAl7dTRQACgkQ538sG/LR dpXMcgf/aGnDZaDpaT7K8y35E0CVbPgFarkAgkDcEFirAQpugKWj/EUo93DXoMor 5q5vy72IpW4R2tZvGYDQ42hltd2n2Y1vOFs13ElgUTqfk7UGUFpBzKXfuLCGY1yN rd+BWgWTK02dSqHyF7Vb+2FVfxNfo27n21btYa7iCMAxFWyDm6xrbONPP/lcu/+O 8wRmAG+51q4rbc9pETQ1KwQc9EZ58hQglXPeUQzzQR+aiCVSP7gud6IXiUOVhmah w/MWl8SRIU1sOjwTkXQha5TDXDq7KxG8Gc4YdmtNQFjW8wz3+msVfjNeeCtFK14u GVB1itG2veq/GAEcSN4X5imlvEFkFA== =Qh5H -----END PGP SIGNATURE----- --6rexytvx3x3wksna--