From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE292C433E0 for ; Mon, 8 Jun 2020 07:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D26022076C for ; Mon, 8 Jun 2020 07:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729075AbgFHHq5 (ORCPT ); Mon, 8 Jun 2020 03:46:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729047AbgFHHq5 (ORCPT ); Mon, 8 Jun 2020 03:46:57 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74FF1C08C5C4 for ; Mon, 8 Jun 2020 00:46:57 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiCUc-0006ou-Jk; Mon, 08 Jun 2020 09:46:50 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jiCUb-000511-Lj; Mon, 08 Jun 2020 09:46:49 +0200 Date: Mon, 8 Jun 2020 09:46:49 +0200 From: Marco Felsch To: Chuhong Yuan Cc: Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: tvp5150: Add missed media_entity_cleanup() Message-ID: <20200608074649.bppdrdoxn6xig6jy@pengutronix.de> References: <20200606143918.2869528-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200606143918.2869528-1-hslester96@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:45:45 up 205 days, 23:04, 198 users, load average: 0.11, 0.08, 0.02 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, thanks for covering that. Appart of the fact that this function does nothing: Reviewed-by: Marco Felsch On 20-06-06 22:39, Chuhong Yuan wrote: > This driver does not call media_entity_cleanup() in the error handler > of tvp5150_registered() and tvp5150_remove(), while it has called > media_entity_pads_init() at first. > Add the missed calls to fix it. > > Fixes: 0556f1d580d4 ("media: tvp5150: add input source selection of_graph support") > Signed-off-by: Chuhong Yuan > --- > drivers/media/i2c/tvp5150.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c > index eb39cf5ea089..9df575238952 100644 > --- a/drivers/media/i2c/tvp5150.c > +++ b/drivers/media/i2c/tvp5150.c > @@ -1664,8 +1664,10 @@ static int tvp5150_registered(struct v4l2_subdev *sd) > return 0; > > err: > - for (i = 0; i < decoder->connectors_num; i++) > + for (i = 0; i < decoder->connectors_num; i++) { > media_device_unregister_entity(&decoder->connectors[i].ent); > + media_entity_cleanup(&decoder->connectors[i].ent); > + } > return ret; > #endif > > @@ -2248,8 +2250,10 @@ static int tvp5150_remove(struct i2c_client *c) > > for (i = 0; i < decoder->connectors_num; i++) > v4l2_fwnode_connector_free(&decoder->connectors[i].base); > - for (i = 0; i < decoder->connectors_num; i++) > + for (i = 0; i < decoder->connectors_num; i++) { > media_device_unregister_entity(&decoder->connectors[i].ent); > + media_entity_cleanup(&decoder->connectors[i].ent); > + } > v4l2_async_unregister_subdev(sd); > v4l2_ctrl_handler_free(&decoder->hdl); > pm_runtime_disable(&c->dev); > -- > 2.26.2 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |