mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Chancellor <natechancellor@gmail.com>
To: Robert Marko <robert.marko@sartura.hr>
Cc: kernel test robot <lkp@intel.com>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	sboyd@kernel.org, Abhishek Sahu <absahu@codeaurora.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	Christian Lamparter <chunkeey@gmail.com>,
	John Crispin <john@phrozen.org>
Subject: Re: [PATCH] clk: qcom: ipq4019: fix apss cpu overclocking
Date: Mon, 8 Jun 2020 02:07:05 -0700	[thread overview]
Message-ID: <20200608090705.GA1597633@ubuntu-n2-xlarge-x86> (raw)
In-Reply-To: <CA+HBbNFpHugbM6LDGAtJHj4ZAz-K5ojkovaVZ04V3QJS-hytUw@mail.gmail.com>

On Mon, Jun 08, 2020 at 10:54:34AM +0200, Robert Marko wrote:
> On Thu, Jun 4, 2020 at 10:25 PM kernel test robot <lkp@intel.com> wrote:
> >
> > Hi Robert,
> >
> > I love your patch! Perhaps something to improve:
> >
> > [auto build test WARNING on clk/clk-next]
> > [also build test WARNING on v5.7 next-20200604]
> > [if your patch is applied to the wrong git tree, please drop us a note to help
> > improve the system. BTW, we also suggest to use '--base' option to specify the
> > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> >
> > url:    https://github.com/0day-ci/linux/commits/Robert-Marko/clk-qcom-ipq4019-fix-apss-cpu-overclocking/20200605-002859
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> > config: x86_64-allyesconfig (attached as .config)
> > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ac47588bc4ff5927a01ed6fcd269ce86aba52a7c)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install x86_64 cross compiling tool for clang build
> >         # apt-get install binutils-x86-64-linux-gnu
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> >
> > >> drivers/clk/qcom/gcc-ipq4019.c:1247:24: warning: no previous prototype for function 'qcom_find_freq_close' [-Wmissing-prototypes]
> > const struct freq_tbl *qcom_find_freq_close(const struct freq_tbl *f,
> > ^
> > drivers/clk/qcom/gcc-ipq4019.c:1247:7: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > const struct freq_tbl *qcom_find_freq_close(const struct freq_tbl *f,
> > ^
> > static
> > 1 warning generated.
> >
> > vim +/qcom_find_freq_close +1247 drivers/clk/qcom/gcc-ipq4019.c
> >
> >   1245
> >   1246
> > > 1247  const struct freq_tbl *qcom_find_freq_close(const struct freq_tbl *f,
> >   1248                                               unsigned long rate)
> >   1249  {
> >   1250          const struct freq_tbl *last = NULL;
> >   1251
> >   1252          for ( ; f->freq; f++) {
> >   1253                  if (rate == f->freq)
> >   1254                          return f;
> >   1255
> >   1256                  if (f->freq > rate) {
> >   1257                          if (!last ||
> >   1258                             (f->freq - rate) < (rate - last->freq))
> >   1259                                  return f;
> >   1260                          else
> >   1261                                  return last;
> >   1262                  }
> >   1263                  last = f;
> >   1264          }
> >   1265
> >   1266          return last;
> >   1267  }
> >   1268
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 

<moved post to the bottom>

> Sorry for asking, but are these warnings relevant?
> GCC9.3 does not throw them
> 
> Regards
> Robert
> 

It should if you are using make W=1, this is not a clang specific
warning (it just happens that clang was the compiler for this report).

It looks like qcom_find_freq_close is only used in
drivers/clk/qcom/gcc-ipq4019.c, in which case it should be marked
static.

Cheers,
Nathan

  reply	other threads:[~2020-06-08  9:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 12:09 Robert Marko
2020-06-04 20:24 ` kernel test robot
2020-06-08  8:54   ` Robert Marko
2020-06-08  9:07     ` Nathan Chancellor [this message]
2020-06-08  9:43       ` Robert Marko
2020-06-08  9:47 Robert Marko
2020-06-09 21:15 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200608090705.GA1597633@ubuntu-n2-xlarge-x86 \
    --to=natechancellor@gmail.com \
    --cc=absahu@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=chunkeey@gmail.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=john@phrozen.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=robert.marko@sartura.hr \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®