From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A2AC433E0 for ; Mon, 8 Jun 2020 12:44:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62F402072F for ; Mon, 8 Jun 2020 12:44:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729140AbgFHMo0 (ORCPT ); Mon, 8 Jun 2020 08:44:26 -0400 Received: from mga11.intel.com ([192.55.52.93]:46985 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728802AbgFHMoZ (ORCPT ); Mon, 8 Jun 2020 08:44:25 -0400 IronPort-SDR: lbm6liwUc1D8W6Z0wohrFf+rgw1bIGt5z5JqEbOiGw/SGFS73bsKNrkpHPE8zS0NMULIj1Wpzw xKA+we5jHdLQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2020 05:44:24 -0700 IronPort-SDR: Ir7ent4kIU9kKCtlp29Gx01dLQtEwFIftDR2b467Wm6HaWsl1f5LcG4ztgNgy42lKgtuKucnuz m/cX3hD6ejKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,487,1583222400"; d="scan'208";a="313867207" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by FMSMGA003.fm.intel.com with ESMTP; 08 Jun 2020 05:44:22 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jiH8b-00BgDF-Es; Mon, 08 Jun 2020 15:44:25 +0300 Date: Mon, 8 Jun 2020 15:44:25 +0300 From: "Shevchenko, Andriy" To: "Wan Mohamad, Wan Ahmad Zainie" Cc: "kishon@ti.com" , "vkoul@kernel.org" , "robh+dt@kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "Hunter, Adrian" Subject: Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support Message-ID: <20200608124425.GK2428291@smile.fi.intel.com> References: <20200608081501.29558-1-wan.ahmad.zainie.wan.mohamad@intel.com> <20200608081501.29558-3-wan.ahmad.zainie.wan.mohamad@intel.com> <20200608100754.GD2428291@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2020 at 01:37:25PM +0300, Wan Mohamad, Wan Ahmad Zainie wrote: > > -----Original Message----- > > From: Shevchenko, Andriy > > On Mon, Jun 08, 2020 at 04:15:01PM +0800, Wan Ahmad Zainie wrote: ... > > > +return PTR_ERR(priv->emmcclk); > > > +} > > > + > > > +return 0; > > > > return PTR_ERR_OR_ZERO(...); > > To clarify, I should replace the block above with, > return PTR_ERR_OR_ZERO(priv->emmcclk); I left the context. -- With Best Regards, Andy Shevchenko