From: Weilong Chen <chenweilong@huawei.com>
To: <christian.brauner@ubuntu.com>, <akpm@linux-foundation.org>,
<tglx@linutronix.de>, <lizefan@huawei.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH linux-next] kernel/fork.c: annotate data races for copy_process
Date: Tue, 9 Jun 2020 11:08:01 +0800 [thread overview]
Message-ID: <20200609030801.272704-1-chenweilong@huawei.com> (raw)
The check is only there to stop root fork bombs.
BUG: KCSAN: data-race in copy_process / copy_process
write to 0xffffffff86f87d20 of 4 bytes by task 7121 on cpu 5:
copy_process+0x2e1a/0x3af0 kernel/fork.c:2285
_do_fork+0xf7/0x790 kernel/fork.c:2430
__do_sys_clone+0xf9/0x130 kernel/fork.c:2585
__se_sys_clone kernel/fork.c:2566 [inline]
__x64_sys_clone+0x6c/0x80 kernel/fork.c:2566
do_syscall_64+0xc7/0x3b0 arch/x86/entry/common.c:295
entry_SYSCALL_64_after_hwframe+0x44/0xa9
read to 0xffffffff86f87d20 of 4 bytes by task 7125 on cpu 3:
copy_process+0x9eb/0x3af0 kernel/fork.c:1967
_do_fork+0xf7/0x790 kernel/fork.c:2430
__do_sys_clone+0xf9/0x130 kernel/fork.c:2585
__se_sys_clone kernel/fork.c:2566 [inline]
__x64_sys_clone+0x6c/0x80 kernel/fork.c:2566
do_syscall_64+0xc7/0x3b0 arch/x86/entry/common.c:295
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
---
kernel/fork.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 142b23645d82..efc5493203ae 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1977,7 +1977,7 @@ static __latent_entropy struct task_struct *copy_process(
* to stop root fork bombs.
*/
retval = -EAGAIN;
- if (nr_threads >= max_threads)
+ if (data_race(nr_threads >= max_threads))
goto bad_fork_cleanup_count;
delayacct_tsk_init(p); /* Must remain after dup_task_struct() */
--
2.17.1
next reply other threads:[~2020-06-09 2:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 3:08 Weilong Chen [this message]
2020-06-09 10:28 ` Christian Brauner
2020-06-17 9:08 Chenweilong
2020-06-17 9:19 ` Zefan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609030801.272704-1-chenweilong@huawei.com \
--to=chenweilong@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®