From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58216C433E0 for ; Tue, 9 Jun 2020 19:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E50E2072F for ; Tue, 9 Jun 2020 19:49:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DVmRoNDb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732002AbgFITtz (ORCPT ); Tue, 9 Jun 2020 15:49:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730817AbgFITtw (ORCPT ); Tue, 9 Jun 2020 15:49:52 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A7A3C03E97C for ; Tue, 9 Jun 2020 12:49:51 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id t16so8441712plo.7 for ; Tue, 09 Jun 2020 12:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BvJL0NnPvCvmgi18G3mhBmcGgjtdbtuvzl/q+YeofAg=; b=DVmRoNDbxYwgNkXXvYn3CI1ZI04NkDYqyMipEJpQRuCUounr0HWR806J2iZRNc3hx3 sw6R7lcSY+tVBAKjajmkBjFh9fMItc5ScRd6O8YMt2dRpK4Xe3eMFuMq8VDepqIzHpfb S8WXDlzBRdReP5RpEVEolQ3Om7T31YcXnLfCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BvJL0NnPvCvmgi18G3mhBmcGgjtdbtuvzl/q+YeofAg=; b=I2Ema7UYi9aGVoAa6EN/3ZhmKmuI5P8KLN7K68ia7pj5QD7z4oDNX07RyrPSqRlztP gTiaSvgXL8GpoNgytQSdha5ebTVq5k+H9VHRikLmrpRCts4KRKWRDlBYhuZouIObyLhO +7b3lu2Go7of9Mh6Nc592I6iB4CgJxxVFlZtilX1p2tF2ivqqyn4JLWyL/YEr2oyDYs3 mV6Vg5pyBb01Xl+QfL4DiTtkcULdnkkfclIZzVNnzjSaJ9DZUqzJ4BpK1umCfC+tDqLh SjN7pvA/4EBjD70ugauK1KunvklGcIIVayu2q4EJrCa+sllnc2RyoAYMcO0/YHLWExxP ZKDw== X-Gm-Message-State: AOAM532Dv3PhACqwZI+z51bpzLuenL0srybyea5TvUjcE6AlDbrh14F+ UfVc/ZpzG96xirbvxRTwZnRKpA== X-Google-Smtp-Source: ABdhPJwh7dWUg2DG7fQ0330c8rWga5xNXIbFNx16XXw8rCe8jyOWReYRCqTemZ/4aIcoimSvV+rHiQ== X-Received: by 2002:a17:902:9882:: with SMTP id s2mr27567plp.112.1591732190608; Tue, 09 Jun 2020 12:49:50 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 145sm10933362pfa.53.2020.06.09.12.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 12:49:49 -0700 (PDT) Date: Tue, 9 Jun 2020 12:49:48 -0700 From: Kees Cook To: David Miller Cc: stephen@networkplumber.org, o.rempel@pengutronix.de, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, kuba@kernel.org, corbet@lwn.net, mkubecek@suse.cz, linville@tuxdriver.com, david@protonic.nl, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux@armlinux.org.uk, mkl@pengutronix.de, marex@denx.de, christian.herber@nxp.com, amitc@mellanox.com, petrm@mellanox.com Subject: Re: [PATCH ethtool v1] netlink: add master/slave configuration support Message-ID: <202006091244.C8B5F9525@keescook> References: <20200609101935.5716b3bd@hermes.lan> <20200609.113633.1866761141966326637.davem@davemloft.net> <202006091222.CB97F743AD@keescook> <20200609.123437.1057990370119930723.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200609.123437.1057990370119930723.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2020 at 12:34:37PM -0700, David Miller wrote: > From: Kees Cook > Date: Tue, 9 Jun 2020 12:29:54 -0700 > > > Given what I've seen from other communities and what I know of the kernel > > community, I don't think we're going to get consensus on some massive > > global search/replace any time soon. However, I think we can get started > > on making this change with just stopping further introductions. (I view > > this like any other treewide change: stop new badness from getting > > added, and chip away as old ones as we can until it's all gone.) > > The terminology being suggested by these changes matches what is used > in the standards and literature. > > Inventing something creates confusion for those who are familiar with > these pieces of technology already, and those who are not who are > reading about it elsewhere. > > Both groups will be terminally confused if we use different words. > > For such pain, there should be agood reason. I don't accept Stephen's > quoted standards bodies "efforts" as a legitimate reason, or evidence > of such, as it has a lot of holes in it as Edward pointed out. I > found the Orwell references to be quite ironic actually. Okay, for now, how about: - If we're dealing with an existing spec, match the language. - If we're dealing with a new spec, ask the authors to fix their language. - If a new version of a spec has updated its language, adjust the kernel's. - If we're doing with something "internal" to the kernel (including UAPI), stop adding new instances. -- Kees Cook