From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E44C433E0 for ; Thu, 11 Jun 2020 01:09:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0008A2078D for ; Thu, 11 Jun 2020 01:09:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726399AbgFKBJ0 (ORCPT ); Wed, 10 Jun 2020 21:09:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbgFKBJ0 (ORCPT ); Wed, 10 Jun 2020 21:09:26 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D51B3C08C5C1; Wed, 10 Jun 2020 18:09:25 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F365C11F5F667; Wed, 10 Jun 2020 18:09:22 -0700 (PDT) Date: Wed, 10 Jun 2020 18:08:26 -0700 (PDT) Message-Id: <20200610.180826.499189657042137494.davem@davemloft.net> To: wang.yi59@zte.com.cn Cc: kuba@kernel.org, mst@redhat.com, hkallweit1@gmail.com, snelson@pensando.io, andriy.shevchenko@linux.intel.com, xiyou.wangcong@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn, wang.liang82@zte.com.cn, liao.pingfang@zte.com.cn Subject: Re: [PATCH v2] net: atm: Remove the error message according to the atomic context From: David Miller In-Reply-To: <1591835930-25941-1-git-send-email-wang.yi59@zte.com.cn> References: <1591835930-25941-1-git-send-email-wang.yi59@zte.com.cn> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 10 Jun 2020 18:09:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yi Wang Date: Thu, 11 Jun 2020 08:38:50 +0800 > @@ -1537,7 +1537,6 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv, > > to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC); > if (!to_return) { > - pr_info("LEC: Arp entry kmalloc failed\n"); > return NULL; > } This now becomes a single-statement basic block and thus the curly braces should be removed.