From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55592C433E0 for ; Wed, 10 Jun 2020 19:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E5882070B for ; Wed, 10 Jun 2020 19:22:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oIEtbNrQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730134AbgFJTWv (ORCPT ); Wed, 10 Jun 2020 15:22:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgFJTWv (ORCPT ); Wed, 10 Jun 2020 15:22:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40F11C03E96B; Wed, 10 Jun 2020 12:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P5rggfV60XhCsWbRt7CAvNpgOpL+AJhTczIH3X0CdJs=; b=oIEtbNrQ1u3XaCtrmnDdBj5uf+ VEN1KBfUJu+CTgd2NYg7Rn0y7FodIFOEKuQ0L9v9uidmJ/4w/hvtnBuRC16gmAu+A3uMLIzQlFmfl 2/R6G36etHTpOpUMaWSMxOb1fsJF8HDwFbHziroy/tvq4i3kpkU5F1k6XeyvWTIL5zgqzc8QQLO2+ X2+LTH4nBfIdXUnfQ8zf44WbodIMF8ULE29R5EihjMQpZ1Ef5HwY0ko1/KhP0m0lOHxdvwlLbJLd5 1N7D4l/Mxb6Xx83IwV1iMCDhCLJwRU5fz+TQeXBy4hlGIpvt0b7vffYIOPyWOuPt76guv6kwAnh5D bL7Oau4w==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jj6JA-00079P-IL; Wed, 10 Jun 2020 19:22:44 +0000 Date: Wed, 10 Jun 2020 12:22:44 -0700 From: Matthew Wilcox To: Markus Elfring Cc: Dan Carpenter , linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Sungjong Seo , Pali =?iso-8859-1?Q?Roh=E1r?= , Tetsuhiro Kohada , Wei Yongjun Subject: Re: [PATCH v2] exfat: add missing brelse() calls on error paths Message-ID: <20200610192244.GK19604@bombadil.infradead.org> References: <20200610172213.GA90634@mwanda> <740ce77a-5404-102b-832f-870cbec82d56@web.de> <20200610184517.GC4282@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 10, 2020 at 08:56:26PM +0200, Markus Elfring wrote: > >>> If the second exfat_get_dentry() call fails then we need to release > >>> "old_bh" before returning. There is a similar bug in exfat_move_file(). > >> > >> Would you like to convert any information from this change description > >> into an imperative wording? > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=5b14671be58d0084e7e2d1cc9c2c36a94467f6e0#n151 > > > > I really feel like imperative doesn't add anything. I understand that > > some people feel really strongly about it, but I don't know why. It > > doesn't make commit messages more understandable. > > Do you insist to deviate from the given guideline? > > > > The important thing is that the problem is clear, the fix is clear and > > the runtime impact is clear. > > I have got further ideas to improve also this commit message. > I am curious if other contributors would like to add another bit of > patch review. You're nitpicking commit messages. This is exactly the kind of thing which drives people away. Dan's commit message is fine. It's actually hilarious because your emails are so unclear that I can't understand them. I have no idea what "collateral evolution" means and yet you use it in almost every email. Why can't you use the same terminology the rest of us use?