mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Scott Branden <scott.branden@broadcom.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Scott Branden <scott.branden@broadcom.com>
Subject: [PATCH] checkpatch: add --max-file-size option
Date: Wed, 10 Jun 2020 13:56:16 -0700	[thread overview]
Message-ID: <20200610205616.9965-1-scott.branden@broadcom.com> (raw)

Add --max-file-size option (default off) to limit size of files
that checkpatch processes.  Such an option is useful when checkpatch
is run automatically during checkins to a source control system and
someone acccidently or purposely attempt to commit massive size files
to the system.  If the checkpatch script runs on such files it could take
a long time to run and limit the server's ability to perform other
operations.

Signed-off-by: Scott Branden <scott.branden@broadcom.com>
---
 scripts/checkpatch.pl | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9fa90457b270..5f0304a9f013 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -53,6 +53,7 @@ my %ignore_type = ();
 my @ignore = ();
 my $help = 0;
 my $configuration_file = ".checkpatch.conf";
+my $max_file_size = -1;
 my $max_line_length = 100;
 my $ignore_perl_version = 0;
 my $minimum_perl_version = 5.10.0;
@@ -99,6 +100,7 @@ Options:
   --types TYPE(,TYPE2...)    show only these comma separated message types
   --ignore TYPE(,TYPE2...)   ignore various comma separated message types
   --show-types               show the specific message type in the output
+  --max-file-size=n          set the maximum file size, if exceeded, exit
   --max-line-length=n        set the maximum line length, (default $max_line_length)
                              if exceeded, warn on patches
                              requires --strict for use with --file
@@ -219,6 +221,7 @@ GetOptions(
 	'types=s'	=> \@use,
 	'show-types!'	=> \$show_types,
 	'list-types!'	=> \$list_types,
+	'max-file-size=i' => \$max_file_size,
 	'max-line-length=i' => \$max_line_length,
 	'min-conf-desc-length=i' => \$min_conf_desc_length,
 	'tab-size=i'	=> \$tabsize,
@@ -1061,6 +1064,15 @@ for my $filename (@ARGV) {
 	} else {
 		$vname = $filename;
 	}
+
+	if ($max_file_size > 0) {
+		my $filesize = -s$FILE;
+
+		if ($filesize > $max_file_size) {
+			die "$P: $filename: filesize:$filesize > $max_file_size\n";
+		}
+	}
+
 	while (<$FILE>) {
 		chomp;
 		push(@rawlines, $_);
-- 
2.17.1


             reply	other threads:[~2020-06-10 20:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 20:56 Scott Branden [this message]
2020-06-10 21:08 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610205616.9965-1-scott.branden@broadcom.com \
    --to=scott.branden@broadcom.com \
    --cc=apw@canonical.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®