From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Frank Haverkamp <haver@linux.ibm.com>
Subject: [PATCH 2/4] misc: genwqe: Constify struct pci_error_handlers
Date: Thu, 11 Jun 2020 00:47:02 +0200 [thread overview]
Message-ID: <20200610224704.27082-3-rikard.falkeborn@gmail.com> (raw)
In-Reply-To: <20200610224704.27082-1-rikard.falkeborn@gmail.com>
genwqe_err_handler is never modified, so it can be made const to allow
the compiler to put it in read-only memory.
Before:
text data bss dec hex filename
20174 6104 2464 28742 7046 drivers/misc/genwqe/card_base.o
After:
text data bss dec hex filename
20270 6008 2464 28742 7046 drivers/misc/genwqe/card_base.o
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/misc/genwqe/card_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 1dc6c7c5cbce..9969c0003f15 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -1324,7 +1324,7 @@ static int genwqe_sriov_configure(struct pci_dev *dev, int numvfs)
return 0;
}
-static struct pci_error_handlers genwqe_err_handler = {
+static const struct pci_error_handlers genwqe_err_handler = {
.error_detected = genwqe_err_error_detected,
.mmio_enabled = genwqe_err_result_none,
.slot_reset = genwqe_err_slot_reset,
--
2.27.0
next prev parent reply other threads:[~2020-06-10 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 22:47 [PATCH 0/4] drivers/misc: Constify static structs Rikard Falkeborn
2020-06-10 22:47 ` [PATCH 1/4] misc: rtsx_usb: Constify struct usb_device_id Rikard Falkeborn
2020-06-10 22:47 ` Rikard Falkeborn [this message]
2020-06-30 7:13 ` [PATCH 2/4] misc: genwqe: Constify struct pci_error_handlers haver
2020-06-10 22:47 ` [PATCH 3/4] mei: hdcp: Constify struct mei_cl_device_id Rikard Falkeborn
2020-06-10 22:47 ` [PATCH 4/4] mic: vop: Constify static structs Rikard Falkeborn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610224704.27082-3-rikard.falkeborn@gmail.com \
--to=rikard.falkeborn@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=haver@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®