From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBB0C433DF for ; Wed, 10 Jun 2020 23:55:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FF55206D9 for ; Wed, 10 Jun 2020 23:55:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbgFJXzR (ORCPT ); Wed, 10 Jun 2020 19:55:17 -0400 Received: from retiisi.org.uk ([95.216.213.190]:58564 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbgFJXzQ (ORCPT ); Wed, 10 Jun 2020 19:55:16 -0400 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 7869E634C87; Thu, 11 Jun 2020 02:55:11 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1jjAYo-0000KR-W7; Thu, 11 Jun 2020 02:55:11 +0300 Date: Thu, 11 Jun 2020 02:55:10 +0300 From: Sakari Ailus To: Andrey Konovalov Cc: mchehab@kernel.org, manivannan.sadhasivam@linaro.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org Subject: Re: [PATCH v4 00/10] Improvements to IMX290 CMOS driver Message-ID: <20200610235510.GC805@valkosipuli.retiisi.org.uk> References: <20200607163025.8409-1-andrey.konovalov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200607163025.8409-1-andrey.konovalov@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrey, On Sun, Jun 07, 2020 at 07:30:15PM +0300, Andrey Konovalov wrote: > This patchset adds improvements to the existing media driver for IMX290 > CMOS sensor from Sony. The major changes are adding 2 lane support, > configurable link frequency & pixel rate, test pattern generation, and > RAW12 mode support. Could you still see what checkpatch.pl says and address the style issues, please? Apart from those this seems fine to me. There are some on msleep() but I wouldn't worry about those. Thanks. -- Sakari Ailus