From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4182FC433E0 for ; Thu, 11 Jun 2020 22:40:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15E9A206D7 for ; Thu, 11 Jun 2020 22:40:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kqd6PapK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbgFKWkf (ORCPT ); Thu, 11 Jun 2020 18:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbgFKWke (ORCPT ); Thu, 11 Jun 2020 18:40:34 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4F53C08C5C1 for ; Thu, 11 Jun 2020 15:40:32 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id x207so3324478pfc.5 for ; Thu, 11 Jun 2020 15:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fLfetYDG8Hj+ZD7+f5tmR+S0GsdbzHMWoDQj21buSPw=; b=kqd6PapK/+TOoz8EkUrOmtB4aQD7tjF70sfmyPZHb4No96IUQQV3TWEzBhf3z8017N ecgy8jS3+kIkONCJxeoUTRC2Fd+wn5/Hbt6sikumR5ZdfFx2UcE+HWglkf9soSsQt824 1QcD7yW7zfet3D62ADeIqR/SxqgaAeBF2xnDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fLfetYDG8Hj+ZD7+f5tmR+S0GsdbzHMWoDQj21buSPw=; b=aytoazfPgopRVmIk7m6OHwkLEa807UItH3bDKvfu2QKGVYAcIRjc3aSZXkgHrY66Wa AfiiN7pcaydNB7bumXY4qOnsdCuDG9s2XpPaJ5gjmSvS+sDuS7YQ1DMaCOQTlHjY4JGc GBGpK0EebbupcVJkcOOU6OQg/k+dAQd+GQDbd1/qSOpiwE5yWKKlsL6t/7cQCb7aLDGV 6FyaAWmjAc4tml2xMrI7TWcsxe64NIaBSfzjnw3K6zBt5lyfvj5fZzS5pTu0jNZNybkc cwBp/OHNM5LISzcy9v+gLxzhd4yb7c1i+iX1wFYK0nCYNdBvYYpd5QP4sqgLoGbEIw5S UpiA== X-Gm-Message-State: AOAM5305jX7Elb/AwqllbEE6CHVfriAnQ74HdbpzpAT2F43UA4c8ULHd 6T54ImfK4ZbPLsa0IgIKUp9H/vzQgGwCZQ== X-Google-Smtp-Source: ABdhPJw4SbI17i9uWSNasj87VfFWE+1K/bw74n/2CXdL6sLZZMpd71TQiHPwGFLBAqUEsOLmmrDPTA== X-Received: by 2002:a63:f502:: with SMTP id w2mr8376139pgh.321.1591915232249; Thu, 11 Jun 2020 15:40:32 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y4sm4162506pfr.182.2020.06.11.15.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 15:40:31 -0700 (PDT) From: Kees Cook To: Shuah Khan Cc: Kees Cook , Christian Brauner , linux-kselftest@vger.kernel.org, Andy Lutomirski , Will Drewry , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH 1/7] selftests/clone3: Reorder reporting output Date: Thu, 11 Jun 2020 15:40:22 -0700 Message-Id: <20200611224028.3275174-2-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200611224028.3275174-1-keescook@chromium.org> References: <20200611224028.3275174-1-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Selftest output reporting was happening before the TAP headers and plan had been emitted. Move the first test reports later. Cc: Christian Brauner Cc: Shuah Khan Cc: linux-kselftest@vger.kernel.org Signed-off-by: Kees Cook --- tools/testing/selftests/clone3/clone3.c | 2 +- tools/testing/selftests/clone3/clone3_clear_sighand.c | 3 +-- tools/testing/selftests/clone3/clone3_set_tid.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c index f14c269a5a18..b7e6dec36173 100644 --- a/tools/testing/selftests/clone3/clone3.c +++ b/tools/testing/selftests/clone3/clone3.c @@ -131,9 +131,9 @@ int main(int argc, char *argv[]) uid_t uid = getuid(); - test_clone3_supported(); ksft_print_header(); ksft_set_plan(17); + test_clone3_supported(); /* Just a simple clone3() should return 0.*/ test_clone3(0, 0, 0, CLONE3_ARGS_NO_TEST); diff --git a/tools/testing/selftests/clone3/clone3_clear_sighand.c b/tools/testing/selftests/clone3/clone3_clear_sighand.c index 9e1af8aa7698..db5fc9c5edcf 100644 --- a/tools/testing/selftests/clone3/clone3_clear_sighand.c +++ b/tools/testing/selftests/clone3/clone3_clear_sighand.c @@ -119,9 +119,8 @@ static void test_clone3_clear_sighand(void) int main(int argc, char **argv) { ksft_print_header(); - test_clone3_supported(); - ksft_set_plan(1); + test_clone3_supported(); test_clone3_clear_sighand(); diff --git a/tools/testing/selftests/clone3/clone3_set_tid.c b/tools/testing/selftests/clone3/clone3_set_tid.c index 25beb22f35b5..5831c1082d6d 100644 --- a/tools/testing/selftests/clone3/clone3_set_tid.c +++ b/tools/testing/selftests/clone3/clone3_set_tid.c @@ -157,8 +157,8 @@ int main(int argc, char *argv[]) pid_t set_tid[MAX_PID_NS_LEVEL * 2]; ksft_print_header(); - test_clone3_supported(); ksft_set_plan(29); + test_clone3_supported(); if (pipe(pipe_1) < 0 || pipe(pipe_2) < 0) ksft_exit_fail_msg("pipe() failed\n"); -- 2.25.1