From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0537C433E0 for ; Fri, 12 Jun 2020 11:56:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9456A20801 for ; Fri, 12 Jun 2020 11:56:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726327AbgFLL4a (ORCPT ); Fri, 12 Jun 2020 07:56:30 -0400 Received: from sym2.noone.org ([178.63.92.236]:40482 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbgFLL4a (ORCPT ); Fri, 12 Jun 2020 07:56:30 -0400 Received: by sym2.noone.org (Postfix, from userid 1002) id 49jzhr5Jnbzvjc1; Fri, 12 Jun 2020 13:56:28 +0200 (CEST) From: Tobias Klauser To: Josh Poimboeuf , Peter Zijlstra Cc: linux-kernel@vger.kernel.org Subject: [PATCH] objtool: Free memory in error case in special_get_alts Date: Fri, 12 Jun 2020 13:56:28 +0200 Message-Id: <20200612115628.8992-1-tklauser@distanz.ch> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoid a memory leak in case get_alt_entry returns an error. Signed-off-by: Tobias Klauser --- tools/objtool/special.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/objtool/special.c b/tools/objtool/special.c index e74e0189de22..f6f7dee1ba77 100644 --- a/tools/objtool/special.c +++ b/tools/objtool/special.c @@ -188,8 +188,10 @@ int special_get_alts(struct elf *elf, struct list_head *alts) memset(alt, 0, sizeof(*alt)); ret = get_alt_entry(elf, entry, sec, idx, alt); - if (ret) + if (ret) { + free(alt); return ret; + } list_add_tail(&alt->list, alts); } -- 2.27.0