From: Mark Brown <broonie@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Takashi Iwai <tiwai@suse.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Vinod Koul <vinod.koul@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [GIT PULL] sound fixes for 5.8-rc1
Date: Fri, 12 Jun 2020 13:19:46 +0100 [thread overview]
Message-ID: <20200612121946.GE5396@sirena.org.uk> (raw)
In-Reply-To: <CALAqxLWEfRJ_Jr0iDgmvqop5Etz5xve89Zy3OeUbnKUGtqjCqQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]
On Thu, Jun 11, 2020 at 05:49:29PM -0700, John Stultz wrote:
> On Thu, Jun 11, 2020 at 5:13 PM John Stultz <john.stultz@linaro.org> wrote:
> > I've bisected it down to the following commit from this pull req:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b73287f0b0745961b14e5ebcce92cc8ed24d4d52
For the benefit of readers that's "ASoC: soc-pcm: dpcm: fix
playback/capture checks".
> I don't know the backgroun again, but would something like the
> following make sense?
> https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/db845c-mainline-WIP&id=7e49b248db77b5ed29b2aa278268e77650c75482
That's a small out of tree test patch which has no changelog so I'm not
entirely clear what the intent or motivation is but it looks like the
goal is to change so that we only warn when a link says it supports
playback/capture but some of the DAIs lack the capability instead of
returning an error. I'm not sure I understand how that helps, it seems
like the link is still misconfigured and we still have a warning which
isn't great? Surely the issue is that we've flagged the link as
supporting capture when it doesn't?
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-12 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 11:33 Takashi Iwai
2020-06-11 19:50 ` pr-tracker-bot
2020-06-12 0:13 ` John Stultz
2020-06-12 0:49 ` John Stultz
2020-06-12 11:41 ` Srinivas Kandagatla
2020-06-12 12:35 ` Mark Brown
2020-06-12 23:59 ` John Stultz
2020-06-12 12:19 ` Mark Brown [this message]
2020-06-12 13:54 ` Pierre-Louis Bossart
2020-06-12 14:46 ` Mark Brown
2020-06-12 14:56 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612121946.GE5396@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@linaro.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®