From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
adrian.hunter@intel.com
Subject: Re: [PATCH v4 2/2] phy: intel: Add Keem Bay eMMC PHY support
Date: Fri, 12 Jun 2020 16:22:31 +0300 [thread overview]
Message-ID: <20200612132231.GH2428291@smile.fi.intel.com> (raw)
In-Reply-To: <20200612035359.14246-3-wan.ahmad.zainie.wan.mohamad@intel.com>
On Fri, Jun 12, 2020 at 11:53:59AM +0800, Wan Ahmad Zainie wrote:
> Add support for eMMC PHY on Intel Keem Bay SoC.
Pretty much good, my comments below.
...
> +config PHY_KEEMBAY_EMMC
> + tristate "Intel Keem Bay EMMC PHY Driver"
> + depends on OF
No compile test?
> + select GENERIC_PHY
> + select REGMAP_MMIO
> + help
> + Enable this to support the Keem Bay EMMC PHY.
Please, be more verbose here, do I, as a user, need this? What will be the module name?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-06-12 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 3:53 [PATCH v4 0/2] " Wan Ahmad Zainie
2020-06-12 3:53 ` [PATCH v4 1/2] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings Wan Ahmad Zainie
2020-06-12 3:53 ` [PATCH v4 2/2] phy: intel: Add Keem Bay eMMC PHY support Wan Ahmad Zainie
2020-06-12 13:22 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612132231.GH2428291@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®