From: Christian Brauner <christian.brauner@ubuntu.com>
To: Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>,
Christian Brauner <christian@brauner.io>,
linux-kselftest@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] selftests: Remove unneeded selftest API headers
Date: Fri, 12 Jun 2020 20:21:05 +0200 [thread overview]
Message-ID: <20200612182105.w22td5jb5g6iltd7@wittgenstein> (raw)
In-Reply-To: <20200611224028.3275174-3-keescook@chromium.org>
On Thu, Jun 11, 2020 at 03:40:23PM -0700, Kees Cook wrote:
> Remove unused includes of the kselftest.h header.
>
> Cc: Christian Brauner <christian@brauner.io>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
Thanks!
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> tools/testing/selftests/pid_namespace/regression_enomem.c | 1 -
> tools/testing/selftests/pidfd/pidfd_getfd_test.c | 1 -
> tools/testing/selftests/pidfd/pidfd_setns_test.c | 1 -
> tools/testing/selftests/uevent/uevent_filtering.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/tools/testing/selftests/pid_namespace/regression_enomem.c b/tools/testing/selftests/pid_namespace/regression_enomem.c
> index 73d532556d17..7d84097ad45c 100644
> --- a/tools/testing/selftests/pid_namespace/regression_enomem.c
> +++ b/tools/testing/selftests/pid_namespace/regression_enomem.c
> @@ -11,7 +11,6 @@
> #include <syscall.h>
> #include <sys/wait.h>
>
> -#include "../kselftest.h"
> #include "../kselftest_harness.h"
> #include "../pidfd/pidfd.h"
>
> diff --git a/tools/testing/selftests/pidfd/pidfd_getfd_test.c b/tools/testing/selftests/pidfd/pidfd_getfd_test.c
> index 401a7c1d0312..eecbf18510fd 100644
> --- a/tools/testing/selftests/pidfd/pidfd_getfd_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_getfd_test.c
> @@ -18,7 +18,6 @@
> #include <linux/kcmp.h>
>
> #include "pidfd.h"
> -#include "../kselftest.h"
> #include "../kselftest_harness.h"
>
> /*
> diff --git a/tools/testing/selftests/pidfd/pidfd_setns_test.c b/tools/testing/selftests/pidfd/pidfd_setns_test.c
> index 133ec5b6cda8..f66861cf9c4d 100644
> --- a/tools/testing/selftests/pidfd/pidfd_setns_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_setns_test.c
> @@ -20,7 +20,6 @@
>
> #include "pidfd.h"
> #include "../clone3/clone3_selftests.h"
> -#include "../kselftest.h"
> #include "../kselftest_harness.h"
>
> enum {
> diff --git a/tools/testing/selftests/uevent/uevent_filtering.c b/tools/testing/selftests/uevent/uevent_filtering.c
> index f83391aa42cf..5cebfb356345 100644
> --- a/tools/testing/selftests/uevent/uevent_filtering.c
> +++ b/tools/testing/selftests/uevent/uevent_filtering.c
> @@ -19,7 +19,6 @@
> #include <sys/wait.h>
> #include <unistd.h>
>
> -#include "../kselftest.h"
> #include "../kselftest_harness.h"
>
> #define __DEV_FULL "/sys/devices/virtual/mem/full/uevent"
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-06-12 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 22:40 [PATCH 0/7] selftests/harness: Switch to TAP output Kees Cook
2020-06-11 22:40 ` [PATCH 1/7] selftests/clone3: Reorder reporting output Kees Cook
2020-06-12 18:19 ` Christian Brauner
2020-06-11 22:40 ` [PATCH 2/7] selftests: Remove unneeded selftest API headers Kees Cook
2020-06-12 18:21 ` Christian Brauner [this message]
2020-06-11 22:40 ` [PATCH 3/7] selftests/binderfs: Fix harness API usage Kees Cook
2020-06-12 18:19 ` Christian Brauner
2020-06-12 18:41 ` Kees Cook
2020-06-11 22:40 ` [PATCH 4/7] selftests: Add header documentation and helpers Kees Cook
2020-06-11 22:40 ` [PATCH 5/7] selftests/harness: Switch to TAP output Kees Cook
2020-06-11 22:40 ` [PATCH 6/7] selftests/harness: Fully track XFAIL reports Kees Cook
2020-06-11 22:40 ` [PATCH 7/7] selftests/harness: Display signed values correctly Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612182105.w22td5jb5g6iltd7@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=shuah@kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®