From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B396CC433E0 for ; Fri, 12 Jun 2020 20:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F86A207ED for ; Fri, 12 Jun 2020 20:47:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbgFLUrB (ORCPT ); Fri, 12 Jun 2020 16:47:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38758 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgFLUrB (ORCPT ); Fri, 12 Jun 2020 16:47:01 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jjqZM-000KbY-Gu; Fri, 12 Jun 2020 22:46:32 +0200 Date: Fri, 12 Jun 2020 22:46:32 +0200 From: Andrew Lunn To: Aditya Pakki Cc: kjlu@umn.edu, wu000273@umn.edu, "David S. Miller" , Jakub Kicinski , Arnd Bergmann , Enrico Weigelt , Allison Randal , Thomas Gleixner , "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: Fix potential memory leak caused in error handling Message-ID: <20200612204632.GB69216@lunn.ch> References: <20200612200656.56019-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200612200656.56019-1-pakki001@umn.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2020 at 03:06:54PM -0500, Aditya Pakki wrote: > In ethoc_probe, a failure of mdiobus_register() does not release > the memory allocated by mdiobus_alloc. The patch fixes this issue. Hi Aditya Please improve the Subject: line to indicate which driver you are fixing. A Fixes: tag would also be nice. Andrew