From: Mark Brown <broonie@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Saravana Kannan <saravanak@google.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH v2 2/2] regulator: Add support for sync_state() callbacks
Date: Mon, 15 Jun 2020 12:49:33 +0100 [thread overview]
Message-ID: <20200615114933.GF4447@sirena.org.uk> (raw)
In-Reply-To: <CAPDyKFohcYjSvBjjB01mg7bOFCJA8XukgRPsZJm48X44sFzeYA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On Mon, Jun 15, 2020 at 12:27:23PM +0200, Ulf Hansson wrote:
> eMMC is not only about voltage levels, but also about enable/disable
> of the regulator(s).
> More precisely, one needs to follow the steps specified in the eMMC
> spec, when disabling the regulator(s).
> In other words, the mmc host driver needs to be probed (consumer of
> the regulator), before the regulator(s) can be disabled.
Right, though you can generally get away with it if you completely cut
the power. The big thing is that as part of this we need to actually do
the things at the time the driver asks for them to be done rather than
some other time.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-15 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 19:06 [PATCH v2 0/2] regulator_sync_state() support Saravana Kannan
2020-05-28 19:06 ` [PATCH v2 1/2] driver core: Add dev_set_drv_sync_state() Saravana Kannan
2020-05-28 19:06 ` [PATCH v2 2/2] regulator: Add support for sync_state() callbacks Saravana Kannan
2020-05-29 13:00 ` Mark Brown
2020-05-30 2:39 ` Saravana Kannan
2020-06-01 17:23 ` Mark Brown
2020-06-09 3:16 ` Saravana Kannan
2020-06-09 10:51 ` Mark Brown
2020-06-15 10:27 ` Ulf Hansson
2020-06-15 11:49 ` Mark Brown [this message]
2020-06-15 15:37 ` Ulf Hansson
2020-05-29 13:09 ` [PATCH v2 0/2] regulator_sync_state() support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615114933.GF4447@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome