mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, peterz@infradead.org,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	morten.rasmussen@arm.com
Subject: [PATCH v2 0/4] sched: Instrument sched domain flags
Date: Tue, 16 Jun 2020 00:41:50 +0100	[thread overview]
Message-ID: <20200615234154.23982-1-valentin.schneider@arm.com> (raw)

Hi,

I've repeatedly stared at an SD flag and asked myself "how should that be
set up in the domain hierarchy anyway?". I figured that if we formalize our
flags zoology a bit, we could also do some runtime assertions on them -
this is what this series is all about.

Patches
=======

The idea is to associate the flags with a metatype that describes how they
should be set in a sched domain hierarchy - details are in the comments and
commit logs. For now it's just a simple parent/children relationship
description ("if this SD has it, all its {parents, children} have it").

The good thing is that this all goes away when CONFIG_SCHED_DEBUG isn't
set. The bad thing is that replaces SD_* flags definitions with some
unsavoury macros. This is mainly because I wanted to avoid having to
duplicate work between declaring the flags and declaring their metatypes.

There's also the removal of yet another SD flag (SD_SHARE_POWERDOMAIN).

Some deltas
===========

This time around it's a slight size increase (w/o SCHED_DEBUG): 

  $ compare.sh before after vmlinux.o
  cpu_attach_domain                                         996       1000   +4
  build_sched_domains                                      4716       4728   +12

Comparing the objdumps side by side, nothing obvious stands out to me.

Revisions
=========

RFC -> v2
---------

RFC at: https://lkml.kernel.org/r/20200311183320.19186-1-valentin.schneider@arm.com

o Rebased on top of tip/sched/core
o Aligned wording of comments between flags
o Rectified some flag descriptions (Morten)
o Added removal of SD_SHARE_POWERDOMAIN (Morten)

Cheers,
Valentin

Valentin Schneider (4):
  sched/topology: Split out SD_* flags declaration to its own file
  sched/topology: Define and assign sched_domain flag metadata
  sched/topology: Verify SD_* flags setup when sched_debug is on
  arm, sched/topology: Remove SD_SHARE_POWERDOMAIN

 arch/arm/kernel/topology.c     |   2 +-
 include/linux/sched/sd_flags.h | 133 +++++++++++++++++++++++++++++++++
 include/linux/sched/topology.h |  29 +++----
 kernel/sched/topology.c        |  27 +++++--
 4 files changed, 169 insertions(+), 22 deletions(-)
 create mode 100644 include/linux/sched/sd_flags.h

--
2.27.0


             reply	other threads:[~2020-06-15 23:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 23:41 Valentin Schneider [this message]
2020-06-15 23:41 ` [PATCH v2 1/4] sched/topology: Split out SD_* flags declaration to its own file Valentin Schneider
2020-06-15 23:41 ` [PATCH v2 2/4] sched/topology: Define and assign sched_domain flag metadata Valentin Schneider
2020-06-15 23:41 ` [PATCH v2 3/4] sched/topology: Verify SD_* flags setup when sched_debug is on Valentin Schneider
2020-06-15 23:41 ` [PATCH v2 4/4] arm, sched/topology: Remove SD_SHARE_POWERDOMAIN Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200615234154.23982-1-valentin.schneider@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®