From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AAE1C433DF for ; Tue, 16 Jun 2020 16:14:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F010721475 for ; Tue, 16 Jun 2020 16:14:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731905AbgFPQOA (ORCPT ); Tue, 16 Jun 2020 12:14:00 -0400 Received: from mga12.intel.com ([192.55.52.136]:20563 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731927AbgFPQNt (ORCPT ); Tue, 16 Jun 2020 12:13:49 -0400 IronPort-SDR: ZgmWzhJ80MG3NItDlDwc9g4M6vmXoIyXCJMPqHUTN6l0LMbkN9mK0Alug+0JYrHHA1vAkrNjyN Uxv1i4c6f8Sg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2020 09:13:46 -0700 IronPort-SDR: s2xxeIxq0R/RHPd43MmtBx3TzSajNMKwChcbJx9i1j44y6nPDxbbZfpk5oN00suBVgKiAOjY07 J+3xB5a1coLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,518,1583222400"; d="scan'208";a="273203116" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003.jf.intel.com with ESMTP; 16 Jun 2020 09:13:44 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1jlEDa-00Drxm-3q; Tue, 16 Jun 2020 19:13:46 +0300 Date: Tue, 16 Jun 2020 19:13:46 +0300 From: Andy Shevchenko To: Nicolas Saenz Julienne Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Rasmus Villemoes , Andrew Morton , Stefan Wahren Subject: Re: [PATCH v3 2/3] ARM: bcm2835: Switch to use %ptT Message-ID: <20200616161346.GW2428291@smile.fi.intel.com> References: <20200415170046.33374-1-andriy.shevchenko@linux.intel.com> <20200415170046.33374-3-andriy.shevchenko@linux.intel.com> <5551ac7d9c7ba7df2b44832af49b3744869b34ef.camel@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5551ac7d9c7ba7df2b44832af49b3744869b34ef.camel@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 05:53:23PM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2020-04-15 at 20:00 +0300, Andy Shevchenko wrote: > > Use %ptT instead of open coded variant to print content of > > time64_t type in human readable format. > > > > Signed-off-by: Andy Shevchenko > > --- > > as originally reported by Stefan Wahren, this patch is likely to be the cause > for a regression on RPi3b+ 32bit mode (multi_v7_defconfig, > 5.8.0-rc1-00019-ga5dc8300df75): > > [ 3.759892] raspberrypi-firmware soc:firmware: Attached to firmware from 18446744073709048425-02-19T15:52:16 > > Whereas the same doesn't seem to happen in 64bit mode: > > [ 1.584126] raspberrypi-firmware soc:firmware: Attached to firmware from 2020-02-12T12:39:27 Had you chance to run test_printf on that machine and see if it reports any failure? If no, can you provide a raw date which makes this happen? Ah, I think I have an idea what is going on... stay tuned! Does below fix it? --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c @@ -181,6 +181,7 @@ EXPORT_SYMBOL_GPL(rpi_firmware_property); static void rpi_firmware_print_firmware_revision(struct rpi_firmware *fw) { + time64_t date_and_time; u32 packet; int ret = rpi_firmware_property(fw, RPI_FIRMWARE_GET_FIRMWARE_REVISION, @@ -189,7 +190,8 @@ rpi_firmware_print_firmware_revision(struct rpi_firmware *fw) if (ret) return; - dev_info(fw->cl.dev, "Attached to firmware from %ptT\n", &packet); + date_and_time = packet; + dev_info(fw->cl.dev, "Attached to firmware from %ptT\n", &date_and_time); } -- With Best Regards, Andy Shevchenko