From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1908AC433E1 for ; Tue, 16 Jun 2020 17:42:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECD16214DB for ; Tue, 16 Jun 2020 17:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592329346; bh=TO5m+hfFv6LoWMR+qPaBMb/tllGHxEHiNIkPu+8psFI=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=uB1h4R3+IKK/oWzBRmvLDcJmHBSDJAqNSJM6vwhA1RvJKlJgDbktDZ3YoHJxrOcsv cgl8c39HaU+vXhWkBwKC+PTGaAy0+jmhru2Y44yv5L0biQkqRFHx7sMmOQ3V6PhnEd T9B/nd5V0XPfqvM9uifjEGwvgUQePCjH0NJkuoIc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730694AbgFPRmY (ORCPT ); Tue, 16 Jun 2020 13:42:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:51126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729771AbgFPRmY (ORCPT ); Tue, 16 Jun 2020 13:42:24 -0400 Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2514F214D8; Tue, 16 Jun 2020 17:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592329343; bh=TO5m+hfFv6LoWMR+qPaBMb/tllGHxEHiNIkPu+8psFI=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=G3cg1bakLwDh6Ob7BoH5jyuwgaHWma0WMo98q8Kcy2vVTB+LWLBjXwKS/JDtnBvFx vuIzWocX3gyf3PPVykHQRrLh+x2RryajRt1mNjPDgqxv7wyQ3k4wu3a8KjR75kYQJV YLok4gPc+HtlfVb48VgC/iW1q7gcHCjGNuviqGwQ= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id BB3AC352264F; Tue, 16 Jun 2020 10:42:22 -0700 (PDT) Date: Tue, 16 Jun 2020 10:42:22 -0700 From: "Paul E. McKenney" To: Marco Elver Cc: linux-kernel@vger.kernel.org, josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, shuah@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] torture: Pass --kmake-arg to all make invocations Message-ID: <20200616174222.GB2723@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200616094924.159539-1-elver@google.com> <20200616160524.GW2723@paulmck-ThinkPad-P72> <20200616164202.GA208325@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200616164202.GA208325@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 06:42:02PM +0200, Marco Elver wrote: > On Tue, Jun 16 2020 at 09:05AM -0700, Paul E. McKenney wrote: > > > On Tue, Jun 16, 2020 at 11:49:24AM +0200, Marco Elver wrote: > > > We need to pass the arguments provided to --kmake-arg to all make > > > invocations. In particular, the make invocations generating the configs > > > need to see the final make arguments, e.g. if config variables depend on > > > particular variables that are passed to make. > > > > > > For example, when using '--kcsan --kmake-arg CC=clang-11', we would lose > > > CONFIG_KCSAN=y due to 'make oldconfig' not seeing that we want to use a > > > compiler that supports KCSAN. > > > > > > Signed-off-by: Marco Elver > > > > Queued and pushed, thank you! > > > > Would the following patch make sense, at least until such time > > as some other compiler supports KCSAN? > > > > Thanx, Paul > > > > ------------------------------------------------------------------------ > > > > commit 88bcaa730b6d40ddf69b09ed6f0a14803d087d99 > > Author: Paul E. McKenney > > Date: Tue Jun 16 09:02:34 2020 -0700 > > > > torture: Make --kcsan default to using Clang 11 > > > > Currently, Clang 11 is the only compiler that can support KCSAN. > > Therefore, as a convenience to the KCSAN user, this commit causes > > --kcsan to specify Clang 11 unless a "CC=" argument was already > > specified via the --kmake-arg argument. > > As soon as more compilers support KCSAN (e.g. clang-12, etc...) we run > the risk of actually inconveniencing ourselves more because then we > really need to say '--kmake-arg CC=clang-1X' to not use the old > compiler. Or revert this in time. > > My command-line looks more like this right now: > > kvm.sh ... --kmake-arg "CC="${HOME}/local/-11.kcsan/local/bin/" ... > > I think the safer alternative would be to error if CONFIG_KCSAN=y is not > in the config, and simply suggest "Did you forget to switch your > compiler with '--kmake-arg CC='?" (of course, a > 'gcc' in $PATH that supports KCSAN would also be fine -- see below). > Eventually, when the default compilers support KCSAN, this will resolve > itself gracefully. > > Also, I'm going to send a series later this week to re-enable GCC > support. ;-) OK, sounds like I should leave well enough alone, then. ;-) In its current state, specifying "--kcsan" without a KCSAN-capable compiler does get you this: :CONFIG_KCSAN=y: improperly set :CONFIG_KCSAN_REPORT_ONCE_IN_MS=100000: improperly set :CONFIG_KCSAN_VERBOSE=y: improperly set :CONFIG_KCSAN_INTERRUPT_WATCHER=y: improperly set Clean KCSAN run in /home/git/linux-rcu/tools/testing/selftests/rcutorture/res/2020.06.16-09.53.16 Which admittedly is a bit obtuse, especially that last line. So how about the following patch, which instead results in this? :CONFIG_KCSAN=y: improperly set :CONFIG_KCSAN_REPORT_ONCE_IN_MS=100000: improperly set :CONFIG_KCSAN_VERBOSE=y: improperly set :CONFIG_KCSAN_INTERRUPT_WATCHER=y: improperly set Did you forget to switch your compiler with --kmake-arg CC=? Thanx, Paul ------------------------------------------------------------------------ commit f571795b1146007407851675a258b6685ea2d589 Author: Paul E. McKenney Date: Tue Jun 16 10:38:57 2020 -0700 torture: Improve diagnostic for KCSAN-incapable compilers Using --kcsan when the compiler does not support KCSAN results in this: :CONFIG_KCSAN=y: improperly set :CONFIG_KCSAN_REPORT_ONCE_IN_MS=100000: improperly set :CONFIG_KCSAN_VERBOSE=y: improperly set :CONFIG_KCSAN_INTERRUPT_WATCHER=y: improperly set Clean KCSAN run in /home/git/linux-rcu/tools/testing/selftests/rcutorture/res/2020.06.16-09.53.16 This is a bit obtuse, so this commit adds checks resulting in this: :CONFIG_KCSAN=y: improperly set :CONFIG_KCSAN_REPORT_ONCE_IN_MS=100000: improperly set :CONFIG_KCSAN_VERBOSE=y: improperly set :CONFIG_KCSAN_INTERRUPT_WATCHER=y: improperly set Did you forget to switch your compiler with --kmake-arg CC=? Suggested-by: Marco Elver Signed-off-by: Paul E. McKenney diff --git a/tools/testing/selftests/rcutorture/bin/kvm-recheck.sh b/tools/testing/selftests/rcutorture/bin/kvm-recheck.sh index 357899c..837643a 100755 --- a/tools/testing/selftests/rcutorture/bin/kvm-recheck.sh +++ b/tools/testing/selftests/rcutorture/bin/kvm-recheck.sh @@ -44,7 +44,8 @@ do then echo QEMU killed fi - configcheck.sh $i/.config $i/ConfigFragment + configcheck.sh $i/.config $i/ConfigFragment > $T 2>&1 + cat $T if test -r $i/Make.oldconfig.err then cat $i/Make.oldconfig.err @@ -73,7 +74,10 @@ do done if test -f "$rd/kcsan.sum" then - if test -s "$rd/kcsan.sum" + if grep -q CONFIG_KCSAN=y $T + then + echo Did you forget to switch your compiler with '--kmake-arg CC='? + elif test -s "$rd/kcsan.sum" then echo KCSAN summary in $rd/kcsan.sum else