From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7245C433E0 for ; Wed, 17 Jun 2020 14:01:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93231214DB for ; Wed, 17 Jun 2020 14:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592402493; bh=hUnhfUy8ysZi64MArixITUGcfaJ7UN86JMKaLY6gF8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=e8J7lIIHPaKhaV+IQG3Nbp92hwXt05qX5PWnwzB33Ug5B4eH/0fbVTekAbHpgZ5po UtVtjFyuWKZ+JjKfmdxwvdVHEqlwxnj4UkeYCNCSwo3fhQe0yUy96eDX/atUNQb04b aoBDAgJjsvnw1Hsvz4whwTsbi0MVxgXcSE64f95U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbgFQOBb (ORCPT ); Wed, 17 Jun 2020 10:01:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:50768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726480AbgFQOBb (ORCPT ); Wed, 17 Jun 2020 10:01:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C031220776; Wed, 17 Jun 2020 14:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592402491; bh=hUnhfUy8ysZi64MArixITUGcfaJ7UN86JMKaLY6gF8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KBjmziXM0RwF2Wh2pT1HiesB3wYDz+I+AmA15dofUucLUfWp0L5baq6hsyufDvDlf wSye0eINt1vlm1AJjwZsiogcpo5wnrCWidFhYpkl4v6jljvwjAUOO1932SYSh8H4ck idVZC7pEb9tONm4p2szkvINVGNCEJK1I6D47A7iM= Date: Wed, 17 Jun 2020 16:01:23 +0200 From: Greg KH To: jim.cromie@gmail.com Cc: Petr Mladek , Jason Baron , LKML , akpm@linuxfoundation.org, Rasmus Villemoes Subject: Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar Message-ID: <20200617140123.GA2588750@kroah.com> References: <20200613155738.2249399-1-jim.cromie@gmail.com> <20200613155738.2249399-20-jim.cromie@gmail.com> <20200616115727.GN31238@alley> <20200617121156.GV31238@alley> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 07:32:44AM -0600, jim.cromie@gmail.com wrote: > hi Petr > > > You made to do some research and I was wrong. For example, getopt() > > operates with options and their arguments. So, 'keyword' and 'arg' names > > look good after all. > > > > Well, I still think that only one syntax should be supported. And it > > is better to distinguish keywords and arguments, so I prefer keyword=arg. > > > > hehe, Im gonna cite some RFC wisdom to convince you ;-) > > Be strict in what you emit, and permissive in what you accept. > > I see no potential for real ambiguity that would override that bias. No, the kernel should be strict in what it accepts, otherwise it is a huge maintance burden for no good reason at all. Only one syntax is a wise idea, stick with that please. thanks, greg k-h