From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C41EC433E0 for ; Wed, 17 Jun 2020 06:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCE7E206F1 for ; Wed, 17 Jun 2020 06:18:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="V8PHZVtK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbgFQGSP (ORCPT ); Wed, 17 Jun 2020 02:18:15 -0400 Received: from ozlabs.org ([203.11.71.1]:52297 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726681AbgFQGSO (ORCPT ); Wed, 17 Jun 2020 02:18:14 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49mvyC3vtXz9sRW; Wed, 17 Jun 2020 16:18:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1592374692; bh=mJkXDcG+JBwronSGoBFKwHoOQWlgz+qa4gI2fl3s5OA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V8PHZVtKEWbc4Z1DZixbQ0OxxIkURvtvl5Fh5EXAMbvxsk+fcG4V1fq2X6bQcKmf6 LFm/ID0UE2wWBOLBVbOHTwYbzddwK/qc3Ndi9qkuZHZ8GapyzcPKb0r3hXObURz925 n0FfWZdIVfDY896dB7j5dHkSYZvZY/a5MXd3Y0fpHdY2adTX1ogqNhHUM/uhwXn5Ap 5YFxggXNkehaHJqWA3nKptq6XmFmZg4n670PI0SNMH5Jojs9+YM3gIQKVV9Ph4QoSN ZoDlIoBcE7EHnlcMHaOIbSPtlEIzJkXUq5FwJVeeZlas4sm3iUOpCWXKXjw5UNDKuz K+CMdNUbIuxyw== Date: Wed, 17 Jun 2020 16:18:10 +1000 From: Stephen Rothwell To: Greg KH Cc: Linux-kernel Mailing List , linux-arch@vger.kernel.org, Arnd Bergmann Subject: Re: [RFC PATCH 1/2] Explicitly include linux/major.h where it is needed Message-ID: <20200617161810.256ff93f@canb.auug.org.au> In-Reply-To: <20200617055843.GB25631@kroah.com> References: <20200617092614.7897ccb2@canb.auug.org.au> <20200617092747.0cadb2de@canb.auug.org.au> <20200617055843.GB25631@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/SR24Am7bJk6gmzp1XI0YNUE"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/SR24Am7bJk6gmzp1XI0YNUE Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Greg, On Wed, 17 Jun 2020 07:58:43 +0200 Greg KH wro= te: > > On Wed, Jun 17, 2020 at 09:27:47AM +1000, Stephen Rothwell wrote: > > This is in preparation for removing the include of major.h where it is > > not needed. > >=20 > > These files were found using > >=20 > > grep -E -L '[<"](uapi/)?linux/major\.h' $(git grep -l -w -f /tmp/xx) > >=20 > > where /tmp/xx contains all the symbols defined in major.h. There were > > a couple of files in that list that did not need the include since the > > references are in comments. > >=20 > > Signed-off-by: Stephen Rothwell =20 >=20 > Any reason this had an RFC, but patch 2/2 did not? I forgot :-) I added RFC just to hopefully get some attention as this is just the start of a long slow use of my "spare" time. > They look good to me, I will be glad to take these, but do you still > want reviews from others for this? It seems simple enough to me... Yeah, well, we all know the simplest patches usually cause the most pain :-) However, I have been fairly careful and it is an easy include file to work with. And I have done my usual build checks, so the linux-next maintainer won't complain about build problems :-) I would like to hear from Arnd, at least, as I don't want to step on his toes (he is having a larger look at our include files). --=20 Cheers, Stephen Rothwell --Sig_/SR24Am7bJk6gmzp1XI0YNUE Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl7ptaIACgkQAVBC80lX 0GzKewf8D3i2VcdXPYbwXP1LbIeTDCjjxRMksxmNwVqp+V+AnAGCrFNYjpXQ0XLG 0gS30xMjpcoGedPZ7TlbKO2u8Gyz5VgUgicU+JXaDbCzkgcxtFEdIZCmkeWg9527 WzQZzxpBeEscgR3FvLylhGKrYbdfQT14dQsbnRQhlm+wHANvZdAC1mpmUPjeS7vn IbG/sr4xzvnHiup3Vy2j0oqgroHqmqCHKUMKaJEdfFBQSHjWsvfvOBFwAiATow3o eq9imn6UvaSEHU/VFKLNHhYtQKt3a4liB9ScnxlFXFyyYgRx/0ZziBcU6ffHqubd in7WwTgUBtvePKUxSDd2tctZFT8VlQ== =YfaS -----END PGP SIGNATURE----- --Sig_/SR24Am7bJk6gmzp1XI0YNUE--