From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBCBC433DF for ; Thu, 18 Jun 2020 02:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FE3C20720 for ; Thu, 18 Jun 2020 02:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592447648; bh=KzqQWBGzgxPDIiM2TLCHuHzA0lbc/p1k8n6t1lUjCWw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Belwg7ICMgPyeWmVE2YwoGq1QaLUQ55295a8alkqC3fbTMHjjjSLHyl1gEefbM892 pF9iVID+eYn6DZSCnggw9Fpsj42DcPOuGA6No5CTEqc6svKRFACmeVAwWo821SVvRo wccQPpftMHRF0CGzKRtlhv883kmg1ZZaxkbu4v2w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387736AbgFRCeH (ORCPT ); Wed, 17 Jun 2020 22:34:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:44336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729338AbgFRBOg (ORCPT ); Wed, 17 Jun 2020 21:14:36 -0400 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A59AD221F0; Thu, 18 Jun 2020 01:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442875; bh=KzqQWBGzgxPDIiM2TLCHuHzA0lbc/p1k8n6t1lUjCWw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U3+/SWfWhMKw+skYhZV1LDxXhYDYVEYLeSzdKBYILRcQ0jD2LidHnzpTCJwXz8beG D2PhS+y4BMlh0J5Zcvn/1KmmYb9DtFNpvbzPPOofZdV811kUToX9Ub6tFAcKQAaf8A nTzpNL0E170FltTo3ZfKASk5sIQg3Yzl21DYYB0Y= Date: Wed, 17 Jun 2020 18:14:33 -0700 From: Jakub Kicinski To: Gaurav Singh Cc: Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , netdev@vger.kernel.org (open list:TC subsystem), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft Message-ID: <20200617181433.4aeee30c@kicinski-fedora-PC1C0HJN> In-Reply-To: <20200618005526.27101-1-gaurav1086@gmail.com> References: <20200618005526.27101-1-gaurav1086@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Jun 2020 20:55:26 -0400 Gaurav Singh wrote: > parent cannot be NULL here since its in the else part > of the if (parent == NULL) condition. Remove the extra > check on parent pointer. > > Signed-off-by: Gaurav Singh Change seems legit, but it obviously doesn't build... > net/sched/sch_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > index 9a3449b56bd6..8c92d00c5c8e 100644 > --- a/net/sched/sch_api.c > +++ b/net/sched/sch_api.c > @@ -1094,7 +1094,7 @@ static int qdisc_graft(struct net_device *dev, struct Qdisc *parent, > > /* Only support running class lockless if parent is lockless */ > if (new && (new->flags & TCQ_F_NOLOCK) && > - parent && !(parent->flags & TCQ_F_NOLOCK)) > + && !(parent->flags & TCQ_F_NOLOCK)) > qdisc_clear_nolock(new); > > if (!cops || !cops->graft)