From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B19C433E0 for ; Thu, 18 Jun 2020 07:41:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0F1B217A0 for ; Thu, 18 Jun 2020 07:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728153AbgFRHlS (ORCPT ); Thu, 18 Jun 2020 03:41:18 -0400 Received: from mga05.intel.com ([192.55.52.43]:30544 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbgFRHlS (ORCPT ); Thu, 18 Jun 2020 03:41:18 -0400 IronPort-SDR: PyS9QxPx83GJgTqRV7LCLEh7+rPwFyVZaET4ecpfgwIrZRrG3Q7iFXbvT14ziAF+QqbU3Lo3oz KVs8LCD9VKkA== X-IronPort-AV: E=McAfee;i="6000,8403,9655"; a="227179317" X-IronPort-AV: E=Sophos;i="5.73,525,1583222400"; d="scan'208";a="227179317" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2020 00:41:17 -0700 IronPort-SDR: hmPEk8+Ta8XZa7xBYxEquUcTyXFqmonbmopCvD6mlJZ0KmkMLQKFIJmdXqmGJTbcsfu2+EL2DP PudKsxxBIExQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,525,1583222400"; d="scan'208";a="273776057" Received: from xpf-desktop.sh.intel.com ([10.239.13.107]) by orsmga003.jf.intel.com with ESMTP; 18 Jun 2020 00:41:10 -0700 Date: Thu, 18 Jun 2020 15:51:04 +0800 From: Pengfei Xu To: Jarkko Sakkinen Cc: Shuah Khan , Heng Su , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Kai Svahn Subject: Re: [Linux] [PATCH] Kernel selftests: tpm2: upgrade tpm2 tests from python2 to python3 Message-ID: <20200618075104.GA13935@xpf-desktop.sh.intel.com> References: <20200618030245.7153-1-pengfei.xu@intel.com> <20200618071858.GD6560@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618071858.GD6560@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jarkko, Thanks for your advice. My feedback is as below. BR. Thanks! On 2020-06-18 at 10:18:58 +0300, Jarkko Sakkinen wrote: > On Thu, Jun 18, 2020 at 11:02:45AM +0800, Pengfei Xu wrote: > > Some Linux OS will never support python2 anymore, so upgrade tpm2 selftests > > to python3. > > > > Signed-off-by: Pengfei Xu > > Linux is a kernel, not a full operating system. Perhaps you mean Linux > distributions? > Will remove [Linux], thanks! > Please capitalize abbrevations correctly (TPM2, not tpm2). Please write > 'Python 2' instead of python2. > Will do, thanks! > With that said the commit message is inaccurate. The root reason for > moving to Python 3 is that Python 2 is no longer supported by the Python > upstream project. Nothing to do with Linux or Linux distributions for > that matter. > Will do, thanks! > /Jarkko