From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B80C433E1 for ; Thu, 18 Jun 2020 14:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34E1B20739 for ; Thu, 18 Jun 2020 14:51:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lTHM5czD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731195AbgFROvH (ORCPT ); Thu, 18 Jun 2020 10:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731152AbgFROvC (ORCPT ); Thu, 18 Jun 2020 10:51:02 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89AF5C0613EF for ; Thu, 18 Jun 2020 07:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=DoID9zoGW91RyxMUWv4e500HCOtNfc1n8lbVfmpATSs=; b=lTHM5czDAtTYXfPLeK2Y0b85jY eTsQ3Se3mV114drLY/tnpYloFlO6ZnAp5sMn34Ce9BKZGIGyIwp6hT7wc0p9Uvaw/Y/qpOhfTtloY zIBBpWuZDgGG/LFu/wSrZh+MQfU0GP9h7nkk23NyUOHZyy/65+8mrr0jbXdw9w6x72/tnsMLQYjBr qLfNWwXY0hFo3u+InDTWub0QK2V3VBh+Ds0607V2sCp8KYCQjZ1D/pI1jA38RSfZni0QmI45KZ5+5 0rgTBM1ILsVJgHUgxVF3A5ntfm/90POxzsZp/dS+GxRjj8Ilh/U/BNiYe+bH/OTtN4lZQIvNiXzZq j/6rGYWg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlvsA-0006Hm-9q; Thu, 18 Jun 2020 14:50:34 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 4693A30753E; Thu, 18 Jun 2020 16:50:32 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 2A4D52146C403; Thu, 18 Jun 2020 16:50:32 +0200 (CEST) Message-ID: <20200618144801.819246178@infradead.org> User-Agent: quilt/0.66 Date: Thu, 18 Jun 2020 16:44:11 +0200 From: Peter Zijlstra To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, x86@kernel.org, dvyukov@google.com, elver@google.com, andreyknvl@google.com, mark.rutland@arm.com, mhelsley@vmware.com, rostedt@goodmis.org, jthierry@redhat.com, mbenes@suse.cz, peterz@infradead.org, Andy Lutomirski Subject: [PATCH 4/7] x86/entry: Increase entry_stack size to a full page References: <20200618144407.520952071@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marco crashed in bad_iret with a Clang11/KCSAN build due to overflowing the stack. Now that we run C code on it, expand it to a full page. Suggested-by: Andy Lutomirski Reported-by: Marco Elver Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -370,7 +370,7 @@ struct x86_hw_tss { #define IO_BITMAP_OFFSET_INVALID (__KERNEL_TSS_LIMIT + 1) struct entry_stack { - unsigned long words[64]; + char stack[PAGE_SIZE]; }; struct entry_stack_page {