From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <dave@stgolabs.net>,
Ingo Molnar <mingo@redhat.com>,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Marco Elver <elver@google.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
"Uladzislau Rezki (Sony)" <urezki@gmail.com>
Subject: Re: [PATCH 4/7] rcu/trace: Print negative GP numbers correctly
Date: Thu, 18 Jun 2020 15:30:45 -0700 [thread overview]
Message-ID: <20200618223045.GB2723@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200618202955.4024-4-joel@joelfernandes.org>
On Thu, Jun 18, 2020 at 04:29:52PM -0400, Joel Fernandes (Google) wrote:
> GP numbers start from -300 and gp_seq numbers start of -1200 (for a
> shift of 2). These negative numbers are printed as unsigned long which
> not only takes up more text space, but is rather confusing to the reader
> as they have to constantly expend energy to truncate the number. Just
> print the negative numbering directly.
Good! This also makes the ftrace versions of the grace-period sequence
numbers consistent with those of rcutorture.
Thanx, Paul
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
> include/trace/events/rcu.h | 62 ++++++++++++++++++++------------------
> 1 file changed, 32 insertions(+), 30 deletions(-)
>
> diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h
> index cb5363564f7ed..bc24862790623 100644
> --- a/include/trace/events/rcu.h
> +++ b/include/trace/events/rcu.h
> @@ -76,18 +76,18 @@ TRACE_EVENT_RCU(rcu_grace_period,
> TP_STRUCT__entry(
> __field(const char *, rcuname)
> __field(const char *, gp_seq_src)
> - __field(unsigned long, gp_seq)
> + __field(long, gp_seq)
> __field(const char *, gpevent)
> ),
>
> TP_fast_assign(
> __entry->rcuname = rcuname;
> __entry->gp_seq_src = gp_seq_src;
> - __entry->gp_seq = gp_seq;
> + __entry->gp_seq = (long)gp_seq;
> __entry->gpevent = gpevent;
> ),
>
> - TP_printk("%s %s_gp_seq=%lu %s",
> + TP_printk("%s %s_gp_seq=%ld %s",
> __entry->rcuname, __entry->gp_seq_src,
> __entry->gp_seq, __entry->gpevent)
> );
> @@ -118,8 +118,8 @@ TRACE_EVENT_RCU(rcu_future_grace_period,
>
> TP_STRUCT__entry(
> __field(const char *, rcuname)
> - __field(unsigned long, gp_seq)
> - __field(unsigned long, gp_seq_req)
> + __field(long, gp_seq)
> + __field(long, gp_seq_req)
> __field(u8, level)
> __field(int, grplo)
> __field(int, grphi)
> @@ -128,16 +128,16 @@ TRACE_EVENT_RCU(rcu_future_grace_period,
>
> TP_fast_assign(
> __entry->rcuname = rcuname;
> - __entry->gp_seq = gp_seq;
> - __entry->gp_seq_req = gp_seq_req;
> + __entry->gp_seq = (long)gp_seq;
> + __entry->gp_seq_req = (long)gp_seq_req;
> __entry->level = level;
> __entry->grplo = grplo;
> __entry->grphi = grphi;
> __entry->gpevent = gpevent;
> ),
>
> - TP_printk("%s %lu %lu %u %d %d %s",
> - __entry->rcuname, __entry->gp_seq, __entry->gp_seq_req, __entry->level,
> + TP_printk("%s %ld %ld %u %d %d %s",
> + __entry->rcuname, (long)__entry->gp_seq, (long)__entry->gp_seq_req, __entry->level,
> __entry->grplo, __entry->grphi, __entry->gpevent)
> );
>
> @@ -157,7 +157,7 @@ TRACE_EVENT_RCU(rcu_grace_period_init,
>
> TP_STRUCT__entry(
> __field(const char *, rcuname)
> - __field(unsigned long, gp_seq)
> + __field(long, gp_seq)
> __field(u8, level)
> __field(int, grplo)
> __field(int, grphi)
> @@ -166,14 +166,14 @@ TRACE_EVENT_RCU(rcu_grace_period_init,
>
> TP_fast_assign(
> __entry->rcuname = rcuname;
> - __entry->gp_seq = gp_seq;
> + __entry->gp_seq = (long)gp_seq;
> __entry->level = level;
> __entry->grplo = grplo;
> __entry->grphi = grphi;
> __entry->qsmask = qsmask;
> ),
>
> - TP_printk("%s %lu %u %d %d %lx",
> + TP_printk("%s %ld %u %d %d %lx",
> __entry->rcuname, __entry->gp_seq, __entry->level,
> __entry->grplo, __entry->grphi, __entry->qsmask)
> );
> @@ -201,17 +201,17 @@ TRACE_EVENT_RCU(rcu_exp_grace_period,
>
> TP_STRUCT__entry(
> __field(const char *, rcuname)
> - __field(unsigned long, gpseq)
> + __field(long, gpseq)
> __field(const char *, gpevent)
> ),
>
> TP_fast_assign(
> __entry->rcuname = rcuname;
> - __entry->gpseq = gpseq;
> + __entry->gpseq = (long)gpseq;
> __entry->gpevent = gpevent;
> ),
>
> - TP_printk("%s %lu %s",
> + TP_printk("%s %ld %s",
> __entry->rcuname, __entry->gpseq, __entry->gpevent)
> );
>
> @@ -320,17 +320,17 @@ TRACE_EVENT_RCU(rcu_preempt_task,
>
> TP_STRUCT__entry(
> __field(const char *, rcuname)
> - __field(unsigned long, gp_seq)
> + __field(long, gp_seq)
> __field(int, pid)
> ),
>
> TP_fast_assign(
> __entry->rcuname = rcuname;
> - __entry->gp_seq = gp_seq;
> + __entry->gp_seq = (long)gp_seq;
> __entry->pid = pid;
> ),
>
> - TP_printk("%s %lu %d",
> + TP_printk("%s %ld %d",
> __entry->rcuname, __entry->gp_seq, __entry->pid)
> );
>
> @@ -347,17 +347,17 @@ TRACE_EVENT_RCU(rcu_unlock_preempted_task,
>
> TP_STRUCT__entry(
> __field(const char *, rcuname)
> - __field(unsigned long, gp_seq)
> + __field(long, gp_seq)
> __field(int, pid)
> ),
>
> TP_fast_assign(
> __entry->rcuname = rcuname;
> - __entry->gp_seq = gp_seq;
> + __entry->gp_seq = (long)gp_seq;
> __entry->pid = pid;
> ),
>
> - TP_printk("%s %lu %d", __entry->rcuname, __entry->gp_seq, __entry->pid)
> + TP_printk("%s %ld %d", __entry->rcuname, __entry->gp_seq, __entry->pid)
> );
>
> /*
> @@ -378,7 +378,7 @@ TRACE_EVENT_RCU(rcu_quiescent_state_report,
>
> TP_STRUCT__entry(
> __field(const char *, rcuname)
> - __field(unsigned long, gp_seq)
> + __field(long, gp_seq)
> __field(unsigned long, mask)
> __field(unsigned long, qsmask)
> __field(u8, level)
> @@ -389,7 +389,7 @@ TRACE_EVENT_RCU(rcu_quiescent_state_report,
>
> TP_fast_assign(
> __entry->rcuname = rcuname;
> - __entry->gp_seq = gp_seq;
> + __entry->gp_seq = (long)gp_seq;
> __entry->mask = mask;
> __entry->qsmask = qsmask;
> __entry->level = level;
> @@ -398,7 +398,7 @@ TRACE_EVENT_RCU(rcu_quiescent_state_report,
> __entry->gp_tasks = gp_tasks;
> ),
>
> - TP_printk("%s %lu %lx>%lx %u %d %d %u",
> + TP_printk("%s %ld %lx>%lx %u %d %d %u",
> __entry->rcuname, __entry->gp_seq,
> __entry->mask, __entry->qsmask, __entry->level,
> __entry->grplo, __entry->grphi, __entry->gp_tasks)
> @@ -419,19 +419,19 @@ TRACE_EVENT_RCU(rcu_fqs,
>
> TP_STRUCT__entry(
> __field(const char *, rcuname)
> - __field(unsigned long, gp_seq)
> + __field(long, gp_seq)
> __field(int, cpu)
> __field(const char *, qsevent)
> ),
>
> TP_fast_assign(
> __entry->rcuname = rcuname;
> - __entry->gp_seq = gp_seq;
> + __entry->gp_seq = (long)gp_seq;
> __entry->cpu = cpu;
> __entry->qsevent = qsevent;
> ),
>
> - TP_printk("%s %lu %d %s",
> + TP_printk("%s %ld %d %s",
> __entry->rcuname, __entry->gp_seq,
> __entry->cpu, __entry->qsevent)
> );
> @@ -520,17 +520,19 @@ TRACE_EVENT_RCU(rcu_segcb,
> TP_STRUCT__entry(
> __field(const char *, ctx)
> __array(int, cb_count, 4)
> - __array(unsigned long, gp_seq, 4)
> + __array(long, gp_seq, 4)
> ),
>
> TP_fast_assign(
> + int i;
> __entry->ctx = ctx;
> memcpy(__entry->cb_count, cb_count, 4 * sizeof(int));
> - memcpy(__entry->gp_seq, gp_seq, 4 * sizeof(unsigned long));
> + for (i = 0; i < 4; i++)
> + __entry->gp_seq[i] = (long)(gp_seq[i]);
> ),
>
> TP_printk("%s cb_count: (DONE=%d, WAIT=%d, NEXT_READY=%d, NEXT=%d) "
> - "gp_seq: (DONE=%lu, WAIT=%lu, NEXT_READY=%lu, NEXT=%lu)", __entry->ctx,
> + "gp_seq: (DONE=%ld, WAIT=%ld, NEXT_READY=%ld, NEXT=%ld)", __entry->ctx,
> __entry->cb_count[0], __entry->cb_count[1], __entry->cb_count[2], __entry->cb_count[3],
> __entry->gp_seq[0], __entry->gp_seq[1], __entry->gp_seq[2], __entry->gp_seq[3])
>
> --
> 2.27.0.111.gc72c7da667-goog
>
next prev parent reply other threads:[~2020-06-18 22:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 20:29 [PATCH 1/7] rcu/segcblist: Prevent useless GP start if no CBs to accelerate Joel Fernandes (Google)
2020-06-18 20:29 ` [PATCH 2/7] rcu/trace: Add tracing for how segcb list changes Joel Fernandes (Google)
2020-06-18 22:16 ` Paul E. McKenney
2020-06-18 23:52 ` Joel Fernandes
2020-06-18 20:29 ` [PATCH 3/7] rcu/trace: Add name of the source for gp_seq Joel Fernandes (Google)
2020-06-18 22:19 ` Paul E. McKenney
2020-06-18 23:51 ` Joel Fernandes
2020-06-19 0:12 ` Paul E. McKenney
2020-06-19 0:56 ` Joel Fernandes
2020-06-19 1:08 ` Joel Fernandes
2020-06-19 0:01 ` Steven Rostedt
2020-06-19 1:01 ` Joel Fernandes
2020-06-18 20:29 ` [PATCH 4/7] rcu/trace: Print negative GP numbers correctly Joel Fernandes (Google)
2020-06-18 22:30 ` Paul E. McKenney [this message]
2020-06-18 20:29 ` [PATCH 5/7] rcu/trace: Use rsp's gp_seq in acceleration's rcu_grace_period tracepoint Joel Fernandes (Google)
2020-06-18 22:27 ` Paul E. McKenney
2020-06-18 23:54 ` Joel Fernandes
2020-06-18 20:29 ` [PATCH 6/7] rcutorture: Add support to get the number of wakeups of main GP kthread Joel Fernandes (Google)
2020-06-18 22:40 ` Paul E. McKenney
2020-06-19 0:01 ` Joel Fernandes
2020-06-19 0:12 ` Paul E. McKenney
2020-06-19 1:00 ` Joel Fernandes
2020-06-19 3:23 ` Paul E. McKenney
2020-06-18 20:29 ` [PATCH 7/7] rcutorture: Add number of GP information to reports Joel Fernandes (Google)
2020-06-18 23:27 ` Paul E. McKenney
2020-06-18 22:11 ` [PATCH 1/7] rcu/segcblist: Prevent useless GP start if no CBs to accelerate Paul E. McKenney
2020-06-18 23:09 ` Paul E. McKenney
2020-06-19 0:04 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618223045.GB2723@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=dave@stgolabs.net \
--cc=elver@google.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®