From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8313EC433E0 for ; Fri, 19 Jun 2020 09:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E70F20776 for ; Fri, 19 Jun 2020 09:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592560465; bh=b2se84h3l52DyW04Q6ULrra7Nh1wmtClcpg6wu/oHFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yK3cEhAXOik7fhZNm4C74FYQmabSPx9smezcDwzCqyVCZORj/iVn8BsJpcU8fFiPt yOW0fTIWBeYWA7HOjopXjkiCk82Ps/1kK8fW1Pp5Q3fSamuGlJftxMzihf9CUAqAL0 ZaVpbEgiMB4L7YEetJLgm6PEPG0+PEXKP7LVxyFk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731989AbgFSJyV (ORCPT ); Fri, 19 Jun 2020 05:54:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:45576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731048AbgFSJyS (ORCPT ); Fri, 19 Jun 2020 05:54:18 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76E6120776; Fri, 19 Jun 2020 09:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592560458; bh=b2se84h3l52DyW04Q6ULrra7Nh1wmtClcpg6wu/oHFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QEsjuS4HYPXHzz8/m/2jC5cXNsBwfCYCKxumbFdkqH6xVxlDMveQvusjboG2Dj7o/ gs6LnYG3n3PmejAkcAV0ip6pnkylUbqSAIUIAPQ47ZdOaIg4t4KRJUlo4O0Tk9K7uE HaqDsY7TvkPrFf0LDf65MeWbZhY+/+QPh+ajee8Y= Date: Fri, 19 Jun 2020 10:54:15 +0100 From: Mark Brown To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Alok Chauhan , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH 6/5] spi: spi-geni-qcom: Simplify setup_fifo_xfer() Message-ID: <20200619095415.GA5396@sirena.org.uk> References: <20200618150626.237027-1-dianders@chromium.org> <20200618233959.160032-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: <20200618233959.160032-1-swboyd@chromium.org> X-Cookie: Robot, n.: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 18, 2020 at 04:39:58PM -0700, Stephen Boyd wrote: > The definition of SPI_FULL_DUPLEX (3) is really SPI_TX_ONLY (1) ORed > with SPI_RX_ONLY (2). Let's drop the define and simplify the code here a > bit by collapsing the setting of 'm_cmd' into conditions that are the > same. Please don't add extra patches after someone else's series like this, it makes things harder to follow and really confuses tooling which tries to parse serieses off the list. Just send a separate series. --PNTmBPCT7hxwcZjr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7si0YACgkQJNaLcl1U h9DGNgf/dEFbdjb6kLp+Q0o2czzyuD3ZIRvlSfE/PF6C8M6Zk2av7RL+CC+X24ve pVOAFd8BKA4qVKaYKQMzXI+YvyH3nj9UnYAkaYhp+4e0seLzFqqibuT3oC0Zsvcu 43/leUWUjRG1IwqAO34o6khhPYGZq86xm8vZVHZdzlag8Z+xsi2fSOG9FX90zloy hH+FfH/vR1otM7fsOFRcg6fKZsz/KrRtkdskQQiJcLXCHgrqsuQvrBEPUvpVR0PR qDDU3uqVb8TuhHeAlf5VYfjb4SjzpOFsXyhh5fukLEjtbiNcCvvJeWGM0uNuw4XM cRR/1HsNX7N3YmX60sd3h/SQcPJfaA== =NiTl -----END PGP SIGNATURE----- --PNTmBPCT7hxwcZjr--