From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jinpu Wang <jinpu.wang@cloud.ionos.com>
Cc: Bo YU <tsu.yubo@gmail.com>,
Danil Kipnis <danil.kipnis@cloud.ionos.com>,
ledford@redhat.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] RDMA/rtrs: fix potential resources leaks
Date: Fri, 19 Jun 2020 11:46:18 -0300 [thread overview]
Message-ID: <20200619144618.GO6578@ziepe.ca> (raw)
In-Reply-To: <CAMGffEntL4XkF6bCuhUDP+AOBO4mpKK1pTe3NgPUW86ySyy7Wg@mail.gmail.com>
On Fri, Jun 19, 2020 at 03:16:57PM +0200, Jinpu Wang wrote:
> Hi, Bo,
> On Fri, Jun 19, 2020 at 3:10 PM Bo YU <tsu.yubo@gmail.com> wrote:
> >
> > Dev is returned from allocation function kzalloc but it does not
> > free it in out_err path.
> If allocation failed, kzalloc return NULL, nothing to free.
You should re-organize this to not confuse coverity.
IS_ERR_OR_NULL should rarely be used and is the problem here
Jason
prev parent reply other threads:[~2020-06-19 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 13:10 Bo YU
2020-06-19 13:16 ` Jinpu Wang
2020-06-19 14:46 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619144618.GO6578@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=danil.kipnis@cloud.ionos.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=ledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tsu.yubo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®