From: Peter Zijlstra <peterz@infradead.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Patrick Bellasi <patrick.bellasi@matbug.net>,
Chris Redpath <chrid.redpath@arm.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sched/uclamp: Fix initialization of strut uclamp_rq
Date: Fri, 19 Jun 2020 19:30:55 +0200 [thread overview]
Message-ID: <20200619173055.GA576888@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200618195525.7889-2-qais.yousef@arm.com>
On Thu, Jun 18, 2020 at 08:55:24PM +0100, Qais Yousef wrote:
> + for_each_clamp_id(clamp_id) {
> + memset(uc_rq[clamp_id].bucket,
> + 0,
> + sizeof(struct uclamp_bucket)*UCLAMP_BUCKETS);
> +
> + uc_rq[clamp_id].value = uclamp_none(clamp_id);
I think you can replace all that with:
*uc_rq = (struct uclamp_rq){
.value = uclamp_none(clamp_id),
};
it's shorter and is free or weird line-breaks :-)
> + }
next prev parent reply other threads:[~2020-06-19 17:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 19:55 [PATCH 0/2] sched: Optionally skip uclamp logic in fast path Qais Yousef
2020-06-18 19:55 ` [PATCH 1/2] sched/uclamp: Fix initialization of strut uclamp_rq Qais Yousef
2020-06-19 10:36 ` Valentin Schneider
2020-06-19 17:30 ` Peter Zijlstra [this message]
2020-06-19 17:39 ` Qais Yousef
2020-06-19 18:13 ` Peter Zijlstra
2020-06-19 18:42 ` Qais Yousef
2020-06-22 10:30 ` Qais Yousef
2020-06-18 19:55 ` [PATCH 2/2] sched/uclamp: Protect uclamp fast path code with static key Qais Yousef
2020-06-19 10:36 ` Valentin Schneider
2020-06-19 11:57 ` Mel Gorman
2020-06-19 12:17 ` Valentin Schneider
2020-06-19 12:55 ` Qais Yousef
2020-06-19 14:51 ` Qais Yousef
2020-06-19 12:51 ` Qais Yousef
2020-06-19 13:23 ` Steven Rostedt
2020-06-19 13:25 ` Valentin Schneider
2020-06-19 14:13 ` Qais Yousef
2020-06-19 15:17 ` Valentin Schneider
2020-06-19 17:25 ` Qais Yousef
2020-06-19 18:52 ` Valentin Schneider
2020-06-19 19:47 ` Peter Zijlstra
2020-06-19 10:39 ` Valentin Schneider
2020-06-19 17:45 ` Peter Zijlstra
2020-06-19 17:53 ` Qais Yousef
2020-06-22 9:06 ` [PATCH 0/2] sched: Optionally skip uclamp logic in fast path Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619173055.GA576888@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=chrid.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=qais.yousef@arm.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome