From: kernel test robot <lkp@intel.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: include/asm-generic/qspinlock.h:94:9: sparse: sparse: context imbalance in 'tcp_get_cookie_sock' - unexpected unlock
Date: Mon, 22 Jun 2020 20:55:08 +0800 [thread overview]
Message-ID: <202006222004.pHVrT6Lb%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2290 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 625d3449788f85569096780592549d0340e9c0c7
commit: f566e1fbadb686e28f1c307e356114b2865ef588 kbuild: make multiple directory targets work
date: 5 months ago
config: openrisc-randconfig-s031-20200622 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-dirty
git checkout f566e1fbadb686e28f1c307e356114b2865ef588
# save the attached .config to linux build tree
make W=1 C=1 ARCH=openrisc CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> include/asm-generic/qspinlock.h:94:9: sparse: sparse: context imbalance in 'tcp_get_cookie_sock' - unexpected unlock
vim +/tcp_get_cookie_sock +94 include/asm-generic/qspinlock.h
a33fda35e3a765 Waiman Long 2015-04-24 83
a33fda35e3a765 Waiman Long 2015-04-24 84 #ifndef queued_spin_unlock
a33fda35e3a765 Waiman Long 2015-04-24 85 /**
a33fda35e3a765 Waiman Long 2015-04-24 86 * queued_spin_unlock - release a queued spinlock
a33fda35e3a765 Waiman Long 2015-04-24 87 * @lock : Pointer to queued spinlock structure
a33fda35e3a765 Waiman Long 2015-04-24 88 */
a33fda35e3a765 Waiman Long 2015-04-24 89 static __always_inline void queued_spin_unlock(struct qspinlock *lock)
a33fda35e3a765 Waiman Long 2015-04-24 90 {
a33fda35e3a765 Waiman Long 2015-04-24 91 /*
ca50e426f96c90 Pan Xinhui 2016-06-03 92 * unlock() needs release semantics:
a33fda35e3a765 Waiman Long 2015-04-24 93 */
626e5fbc143589 Will Deacon 2018-04-26 @94 smp_store_release(&lock->locked, 0);
a33fda35e3a765 Waiman Long 2015-04-24 95 }
a33fda35e3a765 Waiman Long 2015-04-24 96 #endif
a33fda35e3a765 Waiman Long 2015-04-24 97
:::::: The code at line 94 was first introduced by commit
:::::: 626e5fbc14358901ddaa90ce510e0fbeab310432 locking/qspinlock: Use smp_store_release() in queued_spin_unlock()
:::::: TO: Will Deacon <will.deacon@arm.com>
:::::: CC: Ingo Molnar <mingo@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25839 bytes --]
reply other threads:[~2020-06-22 12:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006222004.pHVrT6Lb%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®