From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03488C433DF for ; Tue, 23 Jun 2020 04:09:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D586820780 for ; Tue, 23 Jun 2020 04:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592885358; bh=ZRJiyt96N9POXJVP7NHy1iE13kRK0Ty6Vm6e9HZ9pdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1jvC0C4QXyTNfU6KxbRLDWmDO/xbJxFBi1f0QrUERngB3mX00Y6O10Ly0a3Y7o8Yn Q+SBQTanWG8mw/6g08lKqKXOTVFSO4MsLKArJKCZhjC235bbeJMlkqdetnesLDkNbH thUnJACzdmFH6oYDZpidvohj1eR+3bOMIvLUolHo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732058AbgFWEJR (ORCPT ); Tue, 23 Jun 2020 00:09:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:46204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732100AbgFWEJO (ORCPT ); Tue, 23 Jun 2020 00:09:14 -0400 Received: from localhost (unknown [171.61.66.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FE95208A7; Tue, 23 Jun 2020 04:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592885354; bh=ZRJiyt96N9POXJVP7NHy1iE13kRK0Ty6Vm6e9HZ9pdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GT81H/dR7h27MNGFDfBssIYh31YIzJ0kJgkvPdw3ZuIg8vEN+VBiNFzSUx/clnqV5 76i9o1tJgtjDMR2ioYpVIi2dBvy3ZTg3mirN4jIYKzIavI3R3W8rpyI21vi+QWnlAQ 0B9wtwCgZe+YGtvP+uiQwBuU3jgbe3eGPcaI+oac= Date: Tue, 23 Jun 2020 09:39:10 +0530 From: Vinod Koul To: Charles Keepax Cc: Pierre-Louis Bossart , Takashi Iwai , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, Bjorn Andersson , Srinivas Kandagatla , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] ALSA: compress: document the compress audio state machine Message-ID: <20200623040910.GP2324254@vkoul-mobl> References: <20200622065811.221485-1-vkoul@kernel.org> <20200622065811.221485-2-vkoul@kernel.org> <800a2632-b263-500f-707e-c1ce94ce92d4@linux.intel.com> <20200622151334.GW71940@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622151334.GW71940@ediswmail.ad.cirrus.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-06-20, 15:13, Charles Keepax wrote: > On Mon, Jun 22, 2020 at 08:28:48AM -0500, Pierre-Louis Bossart wrote: > > On 6/22/20 1:58 AM, Vinod Koul wrote: +----------+ > > a) can you clarify if we can go from running to free directly? is > > this really a legit transition? There's already the option of doing > > a stop and a a drain. > > > > This is allowed in the current code, the kernel sends the stop > internally in this case, so it kinda does go through the setup > state just not from the users view point. I am not sure I have a > good handle on if that makes sense or not. The idea was to stop first so that we can handle dmas which might be setup (like running/paused/prepared). So we should stop first and then free up. But i think it was an overkill... :) > > c) no way to stop a paused stream? > > Currently the code does allow this and it certainly makes sense so > should probably be added. Yes will add -- ~Vinod