From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9CBAC433DF for ; Tue, 23 Jun 2020 11:40:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A01020724 for ; Tue, 23 Jun 2020 11:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732430AbgFWLk5 (ORCPT ); Tue, 23 Jun 2020 07:40:57 -0400 Received: from verein.lst.de ([213.95.11.211]:38974 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732332AbgFWLk4 (ORCPT ); Tue, 23 Jun 2020 07:40:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id D029768B05; Tue, 23 Jun 2020 13:40:53 +0200 (CEST) Date: Tue, 23 Jun 2020 13:40:53 +0200 From: Christoph Hellwig To: Eric Auger Cc: eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, peterz@infradead.org, akpm@linux-foundation.org, jean-philippe@linaro.org, bbhushan2@marvell.com Subject: Re: [PATCH] dma-remap: Align the size in dma_common_*_remap() Message-ID: <20200623114053.GB17496@lst.de> References: <20200622202320.1331-1-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622202320.1331-1-eric.auger@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2020 at 10:23:20PM +0200, Eric Auger wrote: > Running a guest with a virtio-iommu protecting virtio devices > is broken since commit 515e5b6d90d4 ("dma-mapping: use vmap insted > of reimplementing it"). Before the conversion, the size was > page aligned in __get_vm_area_node(). Doing so fixes the > regression. > > Fixes: 515e5b6d90d4 ("dma-mapping: use vmap insted of reimplementing it") > Signed-off-by: Eric Auger > --- > kernel/dma/remap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c > index e739a6eea6e7..a3151a9b0c08 100644 > --- a/kernel/dma/remap.c > +++ b/kernel/dma/remap.c > @@ -24,7 +24,7 @@ void *dma_common_pages_remap(struct page **pages, size_t size, > { > void *vaddr; > > - vaddr = vmap(pages, size >> PAGE_SHIFT, VM_DMA_COHERENT, prot); > + vaddr = vmap(pages, PAGE_ALIGN(size) >> PAGE_SHIFT, VM_DMA_COHERENT, prot); Please respin without going over 80 characters.