From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5940EC433DF for ; Wed, 24 Jun 2020 12:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 328AE2088E for ; Wed, 24 Jun 2020 12:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593000717; bh=CQ/YeKAURQSn20ZnWuAL465EuGhpy6ENS1WftOqmBRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bE35vFBxpjk5FmkirHD2q9dFlEBUXgcBxa0FDXjj+32pmWSVQ7T4dMvQwVHOrcwet ycEcmCroHDODOr7vZvrrWgZJ3J37+YaRmDZw2NKwPu427HOkrjjQzsBgf27peZgZoK +LBvlpIC1gY3xo2BlOnWQCFIMtOwTXqMS0DXFkG4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390402AbgFXMLz (ORCPT ); Wed, 24 Jun 2020 08:11:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:47700 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389662AbgFXMLz (ORCPT ); Wed, 24 Jun 2020 08:11:55 -0400 Received: from localhost (unknown [171.61.66.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BBE552088E; Wed, 24 Jun 2020 12:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593000714; bh=CQ/YeKAURQSn20ZnWuAL465EuGhpy6ENS1WftOqmBRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HFhhECB2bBcWWbaA/blSHYyHT2xWdn6egPYPPzlls+ZvlC+cVid/Xz/rwhvxwe0vH /fajBgaTX2hyBmLTS83OZexUHKF9QAi+Mw6/QKn+N2nbZoRBZNcS3ymxHG8HVxr2Kj +6cSNpa7EI23afwb/hfV9/qis8RB9nRo8PHnMm0A= Date: Wed, 24 Jun 2020 17:41:50 +0530 From: Vinod Koul To: Arnd Bergmann Cc: Kishon Vijay Abraham I , Dilip Kota , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] phy: intel: fix enum type mismatch warning Message-ID: <20200624121150.GA2324254@vkoul-mobl> References: <20200527134518.908624-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527134518.908624-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27-05-20, 15:45, Arnd Bergmann wrote: > clang points out that a local variable is initialized with > an enum value of the wrong type: > > drivers/phy/intel/phy-intel-combo.c:202:34: error: implicit conversion from enumeration type 'enum intel_phy_mode' to different enumeration type 'enum intel_combo_mode' [-Werror,-Wenum-conversion] > enum intel_combo_mode cb_mode = PHY_PCIE_MODE; > ~~~~~~~ ^~~~~~~~~~~~~ > > >From reading the code, it seems that this was not only the > wrong type, but not even supposed to be a code path that can > happen in practice. > > Change the code to have no default phy mode but instead return an > error for invalid input. Applied, thanks -- ~Vinod