From: David Miller <davem@davemloft.net>
To: claudiu.beznea@microchip.com
Cc: nicolas.ferre@microchip.com, kuba@kernel.org,
alexandre.belloni@bootlin.com, antoine.tenart@bootlin.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net: macb: free resources on failure path of at91ether_open()
Date: Thu, 25 Jun 2020 16:00:37 -0700 (PDT) [thread overview]
Message-ID: <20200625.160037.879221379667078763.davem@davemloft.net> (raw)
In-Reply-To: <1592993298-26533-2-git-send-email-claudiu.beznea@microchip.com>
From: Claudiu Beznea <claudiu.beznea@microchip.com>
Date: Wed, 24 Jun 2020 13:08:18 +0300
> DMA buffers were not freed on failure path of at91ether_open().
> Along with changes for freeing the DMA buffers the enable/disable
> interrupt instructions were moved to at91ether_start()/at91ether_stop()
> functions and the operations on at91ether_stop() were done in
> their reverse order (compared with how is done in at91ether_start()):
> before this patch the operation order on interface open path
> was as follows:
> 1/ alloc DMA buffers
> 2/ enable tx, rx
> 3/ enable interrupts
> and the order on interface close path was as follows:
> 1/ disable tx, rx
> 2/ disable interrupts
> 3/ free dma buffers.
>
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Also applied and queued up for -stable.
Please submit a proper header posting "[PATCH 0/N] " in the future
when you submit a patch series. Thank you.
next prev parent reply other threads:[~2020-06-25 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 10:08 [PATCH v2 1/2] net: macb: call pm_runtime_put_sync on failure path Claudiu Beznea
2020-06-24 10:08 ` [PATCH v2 2/2] net: macb: free resources on failure path of at91ether_open() Claudiu Beznea
2020-06-25 23:00 ` David Miller [this message]
2020-06-25 23:00 ` [PATCH v2 1/2] net: macb: call pm_runtime_put_sync on failure path David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625.160037.879221379667078763.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.belloni@bootlin.com \
--cc=antoine.tenart@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®