From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41870C433E0 for ; Thu, 25 Jun 2020 15:25:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F500206DD for ; Thu, 25 Jun 2020 15:25:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405845AbgFYPZZ (ORCPT ); Thu, 25 Jun 2020 11:25:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:42772 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404580AbgFYPZY (ORCPT ); Thu, 25 Jun 2020 11:25:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 98981AC9F; Thu, 25 Jun 2020 15:25:23 +0000 (UTC) Date: Thu, 25 Jun 2020 17:25:23 +0200 From: Petr Mladek To: John Ogness Cc: Peter Zijlstra , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Andrea Parri , Thomas Gleixner , Paul McKenney , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: record_printk_text tricks: was: [PATCH v3 3/3] printk: use the lockless ringbuffer Message-ID: <20200625152523.GJ8444@alley> References: <20200618144919.9806-1-john.ogness@linutronix.de> <20200618144919.9806-4-john.ogness@linutronix.de> <20200625120946.GG6156@alley> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625120946.GG6156@alley> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2020-06-25 14:09:46, Petr Mladek wrote: > On Thu 2020-06-18 16:55:19, John Ogness wrote: > > Replace the existing ringbuffer usage and implementation with > > lockless ringbuffer usage. Even though the new ringbuffer does not > > require locking, all existing locking is left in place. Therefore, > > this change is purely replacing the underlining ringbuffer. > > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > +static size_t record_print_text(struct printk_record *r, bool syslog, > > + bool time) [...] > > +static size_t get_record_text_size(struct printk_info *info, > > + unsigned int line_count, > > + bool syslog, bool time) > > +{ Nit: This should get called get_record_print_text_size(). It will make it more clear that it counts the prefixes added for printing. Best Regards, Petr PS: I have finished review of this 3rd patch. I am going to look at the 2nd patch the following week if I find the courage ;-)