mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH 1/9] regulator: max8998: Staticify internal function max8998_get_current_limit()
Date: Fri, 26 Jun 2020 07:57:30 +0100	[thread overview]
Message-ID: <20200626065738.93412-2-lee.jones@linaro.org> (raw)
In-Reply-To: <20200626065738.93412-1-lee.jones@linaro.org>

max8998_get_current_limit() is only used via the .get_current_limit,
so it doesn't need to be publicly supported, or to have its own
external prototype.  Instead, we'll make it static.

Fixes the following W=1 warning:

 drivers/regulator/max8998.c:418:5: warning: no previous prototype for ‘max8998_get_current_limit’ [-Wmissing-prototypes]
 418 | int max8998_get_current_limit(struct regulator_dev *rdev)
 | ^~~~~~~~~~~~~~~~~~~~~~~~~

Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/regulator/max8998.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
index 340413bba0c5f..ac69bdd398cb3 100644
--- a/drivers/regulator/max8998.c
+++ b/drivers/regulator/max8998.c
@@ -415,7 +415,7 @@ static int max8998_set_current_limit(struct regulator_dev *rdev,
 				  sel, rdev->desc->csel_mask);
 }
 
-int max8998_get_current_limit(struct regulator_dev *rdev)
+static int max8998_get_current_limit(struct regulator_dev *rdev)
 {
 	struct max8998_data *max8998 = rdev_get_drvdata(rdev);
 	struct i2c_client *i2c = max8998->iodev->i2c;
-- 
2.25.1


  reply	other threads:[~2020-06-26  6:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26  6:57 [PATCH 0/9] Fix a bunch more W=1 warnings in Regulator Lee Jones
2020-06-26  6:57 ` Lee Jones [this message]
2020-06-26  6:57 ` [PATCH 2/9] regulator: qcom-rpmh-regulator: Repair dodgy kerneldoc header formatting Lee Jones
2020-06-26  7:18   ` Bjorn Andersson
2020-06-26  6:57 ` [PATCH 3/9] regulator: pwm-regulator: Demote kerneldoc header to standard comment Lee Jones
2020-06-26  6:57 ` [PATCH 4/9] regulator: stpmic1_regulator: Properly document 'struct stpmic1_regulator_cfg' Lee Jones
2020-06-26  6:57 ` [PATCH 5/9] regulator: tps65217-regulator: Remove pointless 'is unsigned int <0' check Lee Jones
2020-06-26  6:57 ` [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() Lee Jones
2020-06-26 13:33   ` Mark Brown
2020-06-26 15:31     ` Lee Jones
2020-06-26 15:34       ` Mark Brown
2020-06-26  6:57 ` [PATCH 7/9] regulator: tps65218-regulator: Remove pointless 'is unsigned int <0' check Lee Jones
2020-06-26  6:57 ` [PATCH 8/9] regulator: wm8400-regulator: Repair dodgy kerneldoc header formatting Lee Jones
2020-06-26  9:20   ` Charles Keepax
2020-06-26  6:57 ` [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994_boost' Lee Jones
2020-06-26  7:19   ` Bjorn Andersson
2020-06-26 15:21 ` [PATCH 0/9] Fix a bunch more W=1 warnings in Regulator Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626065738.93412-2-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=broonie@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®