From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] dcssblk: don't set bd_block_size in ->open
Date: Fri, 26 Jun 2020 10:01:53 +0200 [thread overview]
Message-ID: <20200626080158.1998621-3-hch@lst.de> (raw)
In-Reply-To: <20200626080158.1998621-1-hch@lst.de>
bd_block_size contains a value that matches the logic block size when
opening, so the statement is redundant. Even if it wasn't the dumb
assignment would cause a a mismatch with bd_inode->i_blkbits.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/s390/block/dcssblk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
index 384edffe5cb4ae..9c22c6078a4662 100644
--- a/drivers/s390/block/dcssblk.c
+++ b/drivers/s390/block/dcssblk.c
@@ -833,7 +833,6 @@ dcssblk_open(struct block_device *bdev, fmode_t mode)
goto out;
}
atomic_inc(&dev_info->use_count);
- bdev->bd_block_size = 4096;
rc = 0;
out:
return rc;
--
2.26.2
next prev parent reply other threads:[~2020-06-26 8:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 8:01 remove not needed fields from struct block_device Christoph Hellwig
2020-06-26 8:01 ` [PATCH 1/7] floppy: use block_size Christoph Hellwig
2020-06-26 15:48 ` Johannes Thumshirn
2020-06-26 15:50 ` Johannes Thumshirn
2020-06-26 8:01 ` Christoph Hellwig [this message]
2020-06-26 15:54 ` [PATCH 2/7] dcssblk: don't set bd_block_size in ->open Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 3/7] block: simplify set_init_blocksize Christoph Hellwig
2020-06-26 8:01 ` [PATCH 4/7] block: remove the bd_block_size field from struct block_device Christoph Hellwig
2020-07-01 7:29 ` Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 5/7] block: remove the bd_queue " Christoph Hellwig
2020-07-01 7:30 ` Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 6/7] block: remove the unused bd_private " Christoph Hellwig
2020-07-01 7:31 ` Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 7/7] block: remove the all_bdevs list Christoph Hellwig
2020-07-01 7:33 ` Johannes Thumshirn
2020-07-01 7:11 ` remove not needed fields from struct block_device Christoph Hellwig
2020-07-01 15:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626080158.1998621-3-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®