From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7A60C433E2 for ; Fri, 26 Jun 2020 15:34:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77D0B2088E for ; Fri, 26 Jun 2020 15:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593185680; bh=A7IPRyeuP6/3NqZoUgdzauDP9nrPKQlLllURshwLU9M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nq1rbMZ5nLlMWqnI5BSvGLjnAOM2mFtxdTuAVYcfjgLeLk4FrHNoOTe+imIMSlKPL Sxe5eDabe0ntJwike47tWQkMc9qmgiHMAd0GCzmeDAsllXRAfc8ZSle7cIjSMbZ17a lovlSP4olI2+l6Bi5Q1fPgP1Zh2nWuSHP6yhthkE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729535AbgFZPej (ORCPT ); Fri, 26 Jun 2020 11:34:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:45352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726296AbgFZPei (ORCPT ); Fri, 26 Jun 2020 11:34:38 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A8302081A; Fri, 26 Jun 2020 15:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593185678; bh=A7IPRyeuP6/3NqZoUgdzauDP9nrPKQlLllURshwLU9M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x5COMCfnlxSQlGkB0wod1F7ljUsvO/oPxCZZG4w6XULJQJCD3Sgwk5Lpn6ycRLY0Q 8drJcWwHrbjeYsiS0HTGNYFlFNaPbogNKzkroYm5yudeMfhZG5jyZr7sUFtqksVX7P Tc6/r+EyiowFB3CX0PF4RsBRGHl5jq0scrgQbFOI= Date: Fri, 26 Jun 2020 16:34:36 +0100 From: Mark Brown To: Lee Jones Cc: lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russ Dill , Keerthy , AnilKumar Ch , linux-omap@vger.kernel.org Subject: Re: [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() Message-ID: <20200626153436.GA6527@sirena.org.uk> References: <20200626065738.93412-1-lee.jones@linaro.org> <20200626065738.93412-7-lee.jones@linaro.org> <20200626133304.GB5289@sirena.org.uk> <20200626153119.GC177734@dell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <20200626153119.GC177734@dell> X-Cookie: Do not disturb. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 26, 2020 at 04:31:19PM +0100, Lee Jones wrote: > On Fri, 26 Jun 2020, Mark Brown wrote: > > We should really be logging an error there rather than just returning, > > that way it's a bit more apparent to someone debugging things what went > > wrong if there is actually a problem. > Would you like me to fix that up subsequently? That'd be great, yeah! --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl72FYsACgkQJNaLcl1U h9COyQf/WWxpqAzfIH6e2wHDZWmLZGgLpGOgO1ab3hhxJ08G/iU5hVcUJXUT800m KWCkzSxXk1p9v+eCGJ6scUQ850n7/IHdLIgfDDOlyppoxxttet/Zvg7ZXKk4EPUo r7Lwt6N8m01b2dFRKz8rzcMRofDc3PY9dvn7ii1yvjcKrbXwi67AUuSdNjaNrIPB pPFOX8L8BvscOG8Nu1Zx4G04snrrHL76QquV8H5c2G/mqZo69X1eNneRJk6twdZC UwvK5ls/MYaAwDLixW+/ZBbqWb7jAvL75DA9dzN7UTWsp5sPH/jjTnXtuauIIICT MK0DiSlRbBlmAoUmH3fnJa8Ih9IFoA== =0l8u -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--