mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Michael Petlan <mpetlan@redhat.com>,
	Andi Kleen <ak@linux.intel.com>, Kajol Jain <kjain@linux.ibm.com>,
	John Garry <john.garry@huawei.com>,
	"Paul A. Clarke" <pc@us.ibm.com>,
	Stephane Eranian <eranian@google.com>,
	Ian Rogers <irogers@google.com>
Subject: [PATCH 10/10] perf tests: Add cache_miss_cycles to metric parse test
Date: Fri, 26 Jun 2020 21:47:20 +0200	[thread overview]
Message-ID: <20200626194720.2915044-11-jolsa@kernel.org> (raw)
In-Reply-To: <20200626194720.2915044-1-jolsa@kernel.org>

Adding test that compute metric with other metrics in it.

  cache_miss_cycles = metric:dcache_miss_cpi + metric:icache_miss_cycles

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/tests/parse-metric.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.c
index 8c48251425e1..feb97f7c90c8 100644
--- a/tools/perf/tests/parse-metric.c
+++ b/tools/perf/tests/parse-metric.c
@@ -11,6 +11,8 @@
 #include "debug.h"
 #include "expr.h"
 #include "stat.h"
+#include <perf/cpumap.h>
+#include <perf/evlist.h>
 
 static struct pmu_event pme_test[] = {
 {
@@ -22,6 +24,18 @@ static struct pmu_event pme_test[] = {
 			  "( 1 + cpu_clk_unhalted.one_thread_active / cpu_clk_unhalted.ref_xclk ) )))",
 	.metric_name	= "Frontend_Bound_SMT",
 },
+{
+	.metric_expr	= "l1d\\-loads\\-misses / inst_retired.any",
+	.metric_name	= "dcache_miss_cpi",
+},
+{
+	.metric_expr	= "l1i\\-loads\\-misses / inst_retired.any",
+	.metric_name	= "icache_miss_cycles",
+},
+{
+	.metric_expr	= "(metric:dcache_miss_cpi + metric:icache_miss_cycles)",
+	.metric_name	= "cache_miss_cycles",
+},
 };
 
 static struct pmu_events_map map = {
@@ -162,9 +176,28 @@ static int test_frontend(void)
 	return 0;
 }
 
+static int test_cache_miss_cycles(void)
+{
+	double ratio;
+	struct value vals[] = {
+		{ .event = "l1d-loads-misses",  .val = 300 },
+		{ .event = "l1i-loads-misses",  .val = 200 },
+		{ .event = "inst_retired.any",  .val = 400 },
+		{ 0 },
+	};
+
+	TEST_ASSERT_VAL("failed to compute metric",
+			compute_metric("cache_miss_cycles", vals, &ratio) == 0);
+
+	TEST_ASSERT_VAL("cache_miss_cycles failed, wrong ratio",
+			ratio == 1.25);
+	return 0;
+}
+
 int test__parse_metric(struct test *test __maybe_unused, int subtest __maybe_unused)
 {
 	TEST_ASSERT_VAL("IPC failed", test_ipc() == 0);
 	TEST_ASSERT_VAL("frontend failed", test_frontend() == 0);
+	TEST_ASSERT_VAL("cache_miss_cycles failed", test_cache_miss_cycles() == 0);
 	return 0;
 }
-- 
2.25.4


  parent reply	other threads:[~2020-06-26 19:48 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 19:47 [RFC 00/10] perf tools: Add support to reuse metric Jiri Olsa
2020-06-26 19:47 ` [PATCH 01/10] perf tools: Rename expr__add_id to expr__add_val Jiri Olsa
2020-06-26 20:01   ` Ian Rogers
2020-06-28 21:49     ` Jiri Olsa
2020-06-29 15:48       ` Ian Rogers
2020-06-26 19:47 ` [PATCH 02/10] perf tools: Add struct expr_parse_data to keep expr value Jiri Olsa
2020-06-26 20:04   ` Ian Rogers
2020-06-28 21:24     ` Jiri Olsa
2020-06-29 15:49       ` Ian Rogers
2020-06-26 19:47 ` [PATCH 03/10] perf tools: Add expr__add_id function Jiri Olsa
2020-06-26 20:07   ` Ian Rogers
2020-06-28 21:38     ` Jiri Olsa
2020-06-26 19:47 ` [PATCH 04/10] perf tools: Change expr__get_id to return struct expr_parse_data Jiri Olsa
2020-06-26 20:25   ` Ian Rogers
2020-06-26 19:47 ` [PATCH 05/10] perf tools: Add expr__del_id function Jiri Olsa
2020-06-26 20:55   ` Ian Rogers
2020-06-28 21:52     ` Jiri Olsa
2020-06-26 19:47 ` [PATCH 06/10] perf tools: Collect other metrics in struct egroup Jiri Olsa
2020-06-26 21:06   ` Ian Rogers
2020-06-28 22:04     ` Jiri Olsa
2020-06-26 21:48   ` Ian Rogers
2020-06-28 22:06     ` Jiri Olsa
2020-06-29 15:54       ` Ian Rogers
2020-06-26 19:47 ` [PATCH 07/10] perf tools: Collect other metrics in struct metric_expr Jiri Olsa
2020-06-26 21:10   ` Ian Rogers
2020-06-28 21:55     ` Jiri Olsa
2020-06-29 15:55       ` Ian Rogers
2020-06-26 19:47 ` [PATCH 08/10] perf tools: Add other metrics to hash data Jiri Olsa
2020-06-26 21:16   ` Ian Rogers
2020-06-28 21:56     ` Jiri Olsa
2020-06-26 19:47 ` [PATCH 09/10] perf tools: Compute other metrics Jiri Olsa
2020-06-26 21:24   ` Ian Rogers
2020-06-28 21:59     ` Jiri Olsa
2020-06-29 16:35       ` Ian Rogers
2020-06-29 19:23         ` Jiri Olsa
2020-06-26 19:47 ` Jiri Olsa [this message]
2020-06-26 21:40   ` [PATCH 10/10] perf tests: Add cache_miss_cycles to metric parse test Ian Rogers
2020-06-28 22:00     ` Jiri Olsa
2020-06-26 21:25 ` [RFC 00/10] perf tools: Add support to reuse metric Andi Kleen
2020-06-26 21:44   ` Ian Rogers
2020-06-26 21:57     ` Andi Kleen
2020-06-27 12:48       ` Arnaldo Carvalho de Melo
2020-06-27 23:25         ` Ian Rogers
2020-06-28 22:17         ` Jiri Olsa
2020-06-29 12:02       ` Michael Petlan
2020-06-27 12:46     ` Arnaldo Carvalho de Melo
2020-06-27  8:13 ` John Garry
2020-06-29 21:33   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626194720.2915044-11-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=john.garry@huawei.com \
    --cc=kjain@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome