From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9F3C433E0 for ; Sat, 27 Jun 2020 07:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C71B2088E for ; Sat, 27 Jun 2020 07:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593241561; bh=0Qczu/M7GyE6uD82ovyvwKji/pUl3Hpg++uH1cTaKOc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=icXKbp1ApJ6XBfdNmoS2rF4RoDhTppn/+9iXZ8jg8zUS+W0J3qxkmPylDiR1Cj9ES DkVv3rOaXZeGY1giyA2BLllgESKbBBX7U8lzZ2EhNsbOzduHN/Bes6FhJNzoFErjyL 5KQ1voIYqbMA0RSIGDcN0ybZhL44V1GJug8B2Bro= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726110AbgF0HF7 (ORCPT ); Sat, 27 Jun 2020 03:05:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:34476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgF0HF6 (ORCPT ); Sat, 27 Jun 2020 03:05:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DB0A20707; Sat, 27 Jun 2020 07:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593241557; bh=0Qczu/M7GyE6uD82ovyvwKji/pUl3Hpg++uH1cTaKOc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2aX2VibtFKEZAIGK1a70N/BwGTPzLjHOXgx3R5qgpG/fJZLgsVvnaX1yrM8HyE7Zd HrAGgif1//tVh+7NLAlPFGtlvNnnNNhFu5H2vUVaS0zcbO7z+z32mfOKIS3WFrhO6l ikAdf2OekOZSYWmyFlYSwH8XHy6qckxDRCa8JR2g= Date: Sat, 27 Jun 2020 09:05:54 +0200 From: Greg Kroah-Hartman To: B K Karthik Cc: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qlge.h: Adding the missing blank line after declarations Message-ID: <20200627070554.GB264737@kroah.com> References: <20200627060758.aqcqs763rjoxn6cp@pesu-pes-edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200627060758.aqcqs763rjoxn6cp@pesu-pes-edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 27, 2020 at 02:07:58AM -0400, B K Karthik wrote: > Signed-off-by: B K Karthik > --- > drivers/staging/qlge/qlge.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > index fc8c5ca8935d..0b971a633001 100644 > --- a/drivers/staging/qlge/qlge.h > +++ b/drivers/staging/qlge/qlge.h > @@ -2224,6 +2224,7 @@ static inline void ql_write_db_reg_relaxed(u32 val, void __iomem *addr) > static inline u32 ql_read_sh_reg(__le32 *addr) > { > u32 reg; > + > reg = le32_to_cpu(*addr); > rmb(); > return reg; > -- > 2.20.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot