From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B087C433DF for ; Sat, 27 Jun 2020 08:19:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DD782080C for ; Sat, 27 Jun 2020 08:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593245997; bh=4Y3XV82XAfOtPpLYFpPvrfTCFvNM0uZmqgZ2kY8PyMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tCbBbFlN0iy07/Z5VchBOkkuYl0yG19HV78Z4mULubh4FWuGyfwIU/4dWFUH+01Aw DOSMWSJ5xkFYpxkalCAhty/4HeloHE5IkCKZVFwPnKz7l6tobpV3tfo6QE+vSx4TjZ V0O/qL5HDctoH0EHloxYpuk/7JTo2PcvsEjijdxI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbgF0ITz (ORCPT ); Sat, 27 Jun 2020 04:19:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:52354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgF0ITz (ORCPT ); Sat, 27 Jun 2020 04:19:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8497B2080C; Sat, 27 Jun 2020 08:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593245995; bh=4Y3XV82XAfOtPpLYFpPvrfTCFvNM0uZmqgZ2kY8PyMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f6PfUVZByYBOMyFI3n2tZQ83/m0MQKsl4NpXG4jaOkBhVpYLGwIKs8orBHS0Hp94z zDBHi15ocEsw5pSVqNKL8pivEoLLLQr3LAsANAb8T8+Z1QlkcX+TX1i9DVEnotK/ej ZlOOGs1tpxZl0OZEfxpn7f+G/id3yKBUR4z78yaI= Date: Sat, 27 Jun 2020 10:19:48 +0200 From: Greg Kroah-Hartman To: B K Karthik Cc: Larry Finger , Florian Schilhabel , Nishka Dasgupta , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8712: rtl8712_recv.h: Removing unnecessary blank line Message-ID: <20200627081948.GB1550330@kroah.com> References: <20200627080356.6xn3ycyl3zgaddmw@pesu-pes-edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200627080356.6xn3ycyl3zgaddmw@pesu-pes-edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 27, 2020 at 04:03:56AM -0400, B K Karthik wrote: > Removing unnecessary blank line That says what you are doing, but not why you are doing it... Stop, take a day or so, relax, and come back after reading a bunch about how to write a good changelog text (link has been provided to you many times already). There's no rush here. Take the time to get it right so you don't waste other people's time. thanks, greg k-h