From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8445CC433E0 for ; Sat, 27 Jun 2020 13:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EC8620885 for ; Sat, 27 Jun 2020 13:33:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SNKqZfUH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726656AbgF0Nda (ORCPT ); Sat, 27 Jun 2020 09:33:30 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:36760 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725850AbgF0Nd3 (ORCPT ); Sat, 27 Jun 2020 09:33:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593264808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=Qer1iXTJUcRgtSy6CWeiNt2qqL/Nc340WbBo6sqo8Hw=; b=SNKqZfUHh+7L3OvXdN6PsE99UWrpAI84+xh6mpi+iw3PvXjEEOifKYK/h2rgEvlzNAW6NE pXAIyy1wmhMI2d+3zHZ7BT0BGrll45x7fRb4avjxvzZTtSlrzFwJDpBrHv2nE2Q3XnvirC H8ug3Qsm/8OTx5Gd6q8vnXgROv1X44M= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-JyeQVqn5PDSvQ5E9hr_UhQ-1; Sat, 27 Jun 2020 09:33:25 -0400 X-MC-Unique: JyeQVqn5PDSvQ5E9hr_UhQ-1 Received: by mail-qt1-f200.google.com with SMTP id 94so8275733qtb.21 for ; Sat, 27 Jun 2020 06:32:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Qer1iXTJUcRgtSy6CWeiNt2qqL/Nc340WbBo6sqo8Hw=; b=cAjw060f+7TUnrvDbi/yzZqjSDJ6Fn4cN92apgOkjXp8lcLJzCksXUtBHhj0DTVi1c /pFMva/uK+QWLbix7enyeXWdhh/UmgYJQ0h/gc9jQP9UID2NorcPN2c3gf6zmjHEmAhw FtQZMB1V1dGb0vPPJvDJcail1ykZvyBLchjp/biX30DDV39TyYr3bdQgfujxpBLg9tNO 5U0aeviGyZR7KeZKD5Gbg4Z0JJRTDN1IsgXQUqMzdGtseVZsRug4T6WO/Tl2iwYmzGBV mzWFyuA0v9gDv49QZpFew2aeCiP31XBFmgHOzfdEE3Moy4HBW6qPcDYDl86GydI5nlNS rNhQ== X-Gm-Message-State: AOAM53145V4e5rMDQ+g/lwVW3JMb52YnQFmO+s0vCGLpuoHBmripl0oM tKOrO0Y6d8jBixpTPH9BhQIHHGkVulQKB0lmA9DdCTPWr1JnCQ4RoGv1F70kV+bCP0p1bAyGQ2B kWHp1lVFCGbPGh+mHIVk/B4Op X-Received: by 2002:ac8:40cd:: with SMTP id f13mr7446119qtm.373.1593264777902; Sat, 27 Jun 2020 06:32:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTywsDCYj1R1MS3BxIDCt8awqyb1UCPMVd5HfK6pZlMhU6x4aB7OaqYuih/FjYDa/EJvOPwQ== X-Received: by 2002:ac8:40cd:: with SMTP id f13mr7446108qtm.373.1593264777712; Sat, 27 Jun 2020 06:32:57 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id b22sm9767979qka.43.2020.06.27.06.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jun 2020 06:32:57 -0700 (PDT) From: trix@redhat.com To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] scsi: scsi_transport_spi: fix function pointer check. Date: Sat, 27 Jun 2020 06:32:42 -0700 Message-Id: <20200627133242.21618-1-trix@redhat.com> X-Mailer: git-send-email 2.18.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix clang static analysis flags several null function pointer problems. drivers/scsi/scsi_transport_spi.c:374:1: warning: Called function pointer is null (null dereference) [core.CallAndMessage] spi_transport_max_attr(offset, "%d\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reviewing the store_spi_store_max macro if (i->f->set_##field) return -EINVAL; should be if (!i->f->set_##field) return -EINVAL; Signed-off-by: Tom Rix --- drivers/scsi/scsi_transport_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c index f8661062ef95..f3d5b1bbd5aa 100644 --- a/drivers/scsi/scsi_transport_spi.c +++ b/drivers/scsi/scsi_transport_spi.c @@ -339,7 +339,7 @@ store_spi_transport_##field(struct device *dev, \ struct spi_transport_attrs *tp \ = (struct spi_transport_attrs *)&starget->starget_data; \ \ - if (i->f->set_##field) \ + if (!i->f->set_##field) \ return -EINVAL; \ val = simple_strtoul(buf, NULL, 0); \ if (val > tp->max_##field) \ -- 2.18.1