mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Po Liu <po.liu@nxp.com>
To: dsahern@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: stephen@networkplumber.org, davem@davemloft.net,
	jhs@mojatatu.com, vlad@buslov.dev, po.liu@nxp.com,
	claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
	alexandru.marginean@nxp.com
Subject: [v2,iproute2-next 2/2] action police: make 'mtu' could be set independently in police action
Date: Mon, 29 Jun 2020 10:04:20 +0800	[thread overview]
Message-ID: <20200629020420.30412-2-po.liu@nxp.com> (raw)
In-Reply-To: <20200629020420.30412-1-po.liu@nxp.com>

Current police action must set 'rate' and 'burst'. 'mtu' parameter
set the max frame size and could be set alone without 'rate' and 'burst'
in some situation. Offloading to hardware for example, 'mtu' could limit
the flow max frame size.

Signed-off-by: Po Liu <po.liu@nxp.com>
---
v1->v2 changes:
- fix the print message style and add space acked by Stephen Hemminger <stephen@networkplumber.org>

 tc/m_police.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tc/m_police.c b/tc/m_police.c
index 7eb47f8e..83b25db4 100644
--- a/tc/m_police.c
+++ b/tc/m_police.c
@@ -161,8 +161,8 @@ action_ctrl_ok:
 		return -1;
 
 	/* Must at least do late binding, use TB or ewma policing */
-	if (!rate64 && !avrate && !p.index) {
-		fprintf(stderr, "'rate' or 'avrate' MUST be specified.\n");
+	if (!rate64 && !avrate && !p.index && !mtu) {
+		fprintf(stderr, "'rate' or 'avrate' or 'mtu' MUST be specified.\n");
 		return -1;
 	}
 
-- 
2.17.1


  reply	other threads:[~2020-06-29  2:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28  1:46 [iproute2-next] " Po Liu
2020-06-28 20:16 ` Stephen Hemminger
2020-06-29  2:04 ` [v2,iproute2-next 1/2] action police: change the print message quotes style Po Liu
2020-06-29  2:04   ` Po Liu [this message]
2020-06-29  6:54     ` [v2,net-next] net:qos: police action offloading parameter 'burst' change to the original value Po Liu
2020-06-30  0:33       ` David Miller
2020-07-05 15:35   ` [v2,iproute2-next 1/2] action police: change the print message quotes style David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629020420.30412-2-po.liu@nxp.com \
    --to=po.liu@nxp.com \
    --cc=alexandru.marginean@nxp.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vlad@buslov.dev \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®