From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2307CC433E0 for ; Mon, 29 Jun 2020 21:45:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0849206E9 for ; Mon, 29 Jun 2020 21:45:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TqYbZi1I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727797AbgF2Vo6 (ORCPT ); Mon, 29 Jun 2020 17:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727802AbgF2Shp (ORCPT ); Mon, 29 Jun 2020 14:37:45 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96EEAC00F832 for ; Mon, 29 Jun 2020 05:47:58 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 22so15255694wmg.1 for ; Mon, 29 Jun 2020 05:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R3CtQwwHBAUYt5tWEUptOpRirDIZjfKx8cL/+kZ0aGU=; b=TqYbZi1IpvUJDffa5OV7Qjrr0N+cDJ9cZOajkmxHXTv6jjxCNtpB2is8KLr+GUNZ6D wsWKBVDUmapCkLaM/97Mquh2EEnsU4aZLcuUyRYGkjA9TdTd3MvA8NhMxPf9bSdIUiuf sesF6dNfGI25PtjY4+evZRcAg+Pj/rNSZgcudJgTOg4rBIkEPZhFvFPt/hTc20elA1AT W07BruFYC45AsFzkmPBPtwvfC9B5Cbe1Zdirxm0UNAQ8oGSf3UL5DJtsts8XTQsP4Oec +2n10RLzXOTsbHl6bR1aWOWxe0cfxgqBp4/RhSW6l0vlVG6pun/AG8d7Vahpwcdjd/br RGXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R3CtQwwHBAUYt5tWEUptOpRirDIZjfKx8cL/+kZ0aGU=; b=q8Q2sx81CQvZqFflogCnDpblswayfbvAllX860i39M5czLuNdpPMrp4ADnD8EAivGs Dev7nwMxTELpHVwIT+nKx5j3JY+Sf1tZpTwxRN7K9NIGmidgCKwWm4ryVlQhcK3BPI6s BvqPXSzFCCRHKo3hQQUE4L99CvvwsZFBmcDJgs7TIK5KHmPgLGTJe1bQ6aS2HPgh7uDQ r5ciRV1NmPXRgY6oDPjqGxaLXYyLpbPwvvbvZt+LinmWbxm4LW/TSP3ouLkZc75lT5dt 2Eyew6EHqaUqXja7l8lwP0DM2/tMj9cOxEg76LjirOD4v/nuCOFOK/H+R1fNaWmg9BgY HYgw== X-Gm-Message-State: AOAM530qEdYy3Pvwo5yYjkQfkx/iaE92ll3wr/ZuN4rDVufkjvyR3DC8 WouaRIpNnSFI8/CpMbEwO9sXZg== X-Google-Smtp-Source: ABdhPJxeGeJLZE8P8dHdFHVkY80hy0oIW4BMYmEqs8sF7naCIUyVXxBQDOR2f7ZO+bDIvrZQdliD6w== X-Received: by 2002:a7b:c055:: with SMTP id u21mr16091687wmc.132.1593434877370; Mon, 29 Jun 2020 05:47:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id e17sm12995924wrr.88.2020.06.29.05.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 05:47:56 -0700 (PDT) From: Lee Jones To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Subject: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle Date: Mon, 29 Jun 2020 13:47:50 +0100 Message-Id: <20200629124752.1018358-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629124752.1018358-1-lee.jones@linaro.org> References: <20200629124752.1018358-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'dc' here is an unsigned long, thus checking for <0 will always evaluate to false. Fixes the following W=1 warning: drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cc: Florian Fainelli Cc: Ray Jui Cc: Scott Branden Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-pwm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/pwm/pwm-bcm-kona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 81da91df2529a..16c5898b934a8 100644 --- a/drivers/pwm/pwm-bcm-kona.c +++ b/drivers/pwm/pwm-bcm-kona.c @@ -138,7 +138,7 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm, dc = div64_u64(val, div); /* If duty_ns or period_ns are not achievable then return */ - if (pc < PERIOD_COUNT_MIN || dc < DUTY_CYCLE_HIGH_MIN) + if (pc < PERIOD_COUNT_MIN) return -EINVAL; /* If pc and dc are in bounds, the calculation is done */ -- 2.25.1