mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
	linux-pwm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	John Crispin <blogic@openwrt.org>, Zhi Mao <zhi.mao@mediatek.com>,
	linux-mediatek@lists.infradead.org
Subject: [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg
Date: Mon, 29 Jun 2020 13:47:51 +0100	[thread overview]
Message-ID: <20200629124752.1018358-4-lee.jones@linaro.org> (raw)
In-Reply-To: <20200629124752.1018358-1-lee.jones@linaro.org>

Kerneldoc syntax is used, but not complete.

Descriptions are required for all arguments.

Fixes the following W=1 build warning:

 drivers/pwm/pwm-mediatek.c:57: warning: Function parameter or member 'soc' not described in 'pwm_mediatek_chip'

Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: John Crispin <blogic@openwrt.org>
Cc: Zhi Mao <zhi.mao@mediatek.com>
Cc: linux-pwm@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/pwm/pwm-mediatek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
index b94e0d09c300f..ab001ce55178e 100644
--- a/drivers/pwm/pwm-mediatek.c
+++ b/drivers/pwm/pwm-mediatek.c
@@ -46,6 +46,7 @@ struct pwm_mediatek_of_data {
  * @clk_main: the clock used by PWM core
  * @clk_pwms: the clock used by each PWM channel
  * @clk_freq: the fix clock frequency of legacy MIPS SoC
+ * @soc: pointer to chip's platform data
  */
 struct pwm_mediatek_chip {
 	struct pwm_chip chip;
-- 
2.25.1


  parent reply	other threads:[~2020-06-29 18:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 12:47 [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Lee Jones
2020-06-29 12:47 ` [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Lee Jones
2020-06-29 16:45   ` Florian Fainelli
2020-06-29 16:54     ` Scott Branden
2020-06-29 19:45   ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 2/4] pwm: bcm-kona: " Lee Jones
2020-06-29 16:45   ` Florian Fainelli
2020-06-29 19:41     ` Uwe Kleine-König
2020-06-29 12:47 ` Lee Jones [this message]
2020-06-29 19:47   ` [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header Lee Jones
2020-06-29 19:39   ` Uwe Kleine-König
2020-07-27  7:50 ` [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629124752.1018358-4-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=blogic@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=zhi.mao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®